Optional vpacket logging WIP #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Try with this PR @aoifeboyle, I think I fixed your thing. |
|
Will do and will let you know. Thank you @orbitfold. |
|
@orbitfold Working now, thank you. |
|
Glad to hear it worked :) |
Closed
| @@ -423,13 +423,14 @@ montecarlo_one_packet (storage_model_t * storage, rpacket_t * packet, | |||
| rpacket_get_energy (packet) * doppler_factor_ratio); | |||
| rpacket_set_nu(&virt_packet,rpacket_get_nu (packet) * doppler_factor_ratio); | |||
| reabsorbed = montecarlo_one_packet_loop (storage, &virt_packet, 1, mt_state); | |||
| #ifdef WITH_VPACKET_LOGGING | |||
| if ((rpacket_get_nu(&virt_packet) < storage->spectrum_end_nu) && | |||
There was a problem hiding this comment.
The ifdef block is also activates/deactivates the setting of
storage->spectrum_virt_nu[virt_id_nu] in line 455. This is crucial part of calculating and storing the virtual spectrum. This part should live outside the ifdef vpacketlogging block. See #445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.