Fix for zeta issues. #412
Merged
Fix for zeta issues. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,6 +153,8 @@ class ZetaData(BaseAtomicDataProperty): | |||
| outputs = ('zeta_data',) | |||
|
|
|||
| def _filter_atomic_property(self, zeta_data, selected_atoms): | |||
| for temperature in range(42000, 82000, 2000): | |||
There was a problem hiding this comment.
We should extrapolate and not increase the storage. I mean in the end how far it is outside -> outside means use the last valid value
|
@aoifeboyle instead of using |
|
@wkerzendorf Ok, I've had a look at that and it only works with 1-D arrays for the x and y values, so it will only work if I create a loop and interpolate individually for each ion. Is that alright? |
|
@aoifeboyle - that's right. I'm just fixing this - I'll make a PR to your PR. I should be done momentarily. We can also skype if you want. |
|
@aoifeboyle I made a PR to your PR. have a look and merge if happy. |
Plasma/ab zeta fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to issue #411