Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas macroatom issue fix #405

Merged
merged 5 commits into from
Aug 28, 2015
Merged

Conversation

aoifeboyle
Copy link
Contributor

Alternative fix to issue #402 that seems to remove all of the errors.

@ssim This removes all of the errors for me with pandas 0.16.2 (using the config. file you provided). Could you checkout this PR and check it works for you too?

The problem seems to arise when a column is added to a dataframe with an unsorted index. I think the warning is intended to highlight that the index is unsorted and therefore that the data being added may not match up with the index correctly. But the use of .insert() with the data in Pandas series form seems to work, probably because the index of the new data is then specified. That's my understanding of it anyway.

@wkerzendorf
Copy link
Member

@aoifeboyle thanks! good catch

@ssim
Copy link
Contributor

ssim commented Aug 28, 2015

@aoifeboyle Yes - this seems to clear it up perfectly for me! Good work!

@wkerzendorf - if you are also happy with this, let's merge it?

wkerzendorf added a commit that referenced this pull request Aug 28, 2015
@wkerzendorf wkerzendorf merged commit 929a678 into tardis-sn:master Aug 28, 2015
@aoifeboyle aoifeboyle deleted the pandas_issue branch August 29, 2015 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants