More cleanups #398
Merged
More cleanups #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mreineck we have the convention that if you want to continue to work on a PR make the title "[WIP] my fancy title". If you're done let us know and we can quickly check (the idea is that two people sign off on the code before merging [the one that is submitting and someone else]). You can also get merge rights if you want. Drop me an email. |
|
@mreineck should this be merged? |
|
As long as this doen't complicate other merges, it would be great if it could go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more cleanups and a first stab at implementing better dependencies in the build system.