Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More work on cmontecarlo.c and the unit tests #391

Merged
merged 5 commits into from
Aug 21, 2015
Merged

More work on cmontecarlo.c and the unit tests #391

merged 5 commits into from
Aug 21, 2015

Conversation

mreineck
Copy link
Contributor

cmontecarlo.c and cmontecarlo.h:

  • some functions rearranged to allow better inlining
  • specify "const" in the interfaces where appropriate
  • add FIXME comments in places where I suspect problems but can't fix them myself
  • minor performance tweaks (replacing divisions by multiplications etc.)
  • unify variable declaration/definition where possible

Tests:

  • avoid memory leaks in test_rpacket.c
  • fix initialisations in test_montecarlo.c

@wkerzendorf
Copy link
Member

@mreineck if you want to discuss again, bigger restructuring let me know. This looks very good - thank you!

@mreineck
Copy link
Contributor Author

Hmm, the bound_free test still fails on Travis. Can't reproduce it locally. Xfailing it again...

@wkerzendorf
Copy link
Member

travis is running on docker containers on ubuntu as far as I understand.

@mreineck
Copy link
Contributor Author

I'm now done with the things that seemed most urgent to me. Performance-wise I don't see any more low-hanging fruit.
The cmontecarlo tests definitely need reworking though - but I fear I'm not really qualified for this.

@wkerzendorf
Copy link
Member

looks good!

wkerzendorf added a commit that referenced this pull request Aug 21, 2015
More work on cmontecarlo.c and the unit tests
@wkerzendorf wkerzendorf merged commit de89246 into tardis-sn:master Aug 21, 2015
@mreineck mreineck deleted the cleanups branch August 31, 2015 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants