-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves non-physical input check outsode I/O module #2923
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9716029
moves non-physical input check
Sonu0305 1a1d8b9
fixes codespell failure as in #2908
Sonu0305 d6609b3
updated mailmap
Sonu0305 aa7a3ed
fixes codespell failure as in #2908
Sonu0305 cab6bd6
Merge branch 'tardis-sn:master' into fix#2681
Sonu0305 3fd4ab7
made necessary changes to path
Sonu0305 7a77bff
Revert "fixes codespell failure as in #2908"
Sonu0305 30560cc
Revert "fixes codespell failure as in #2908"
Sonu0305 d78865c
Rename test_radiation_field.py to validate_radiation_field.py
Sonu0305 0fdc3fb
Update parse_radiation_field_configuration.py
Sonu0305 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -215,6 +215,8 @@ Stuart Sim <[email protected]> ssim <[email protected]> | |
Stuart Sim <[email protected]> Stuart Sim <[email protected]> | ||
Stuart Sim <[email protected]> Stuart Sim <[email protected]> | ||
|
||
Swayam Shah <[email protected]> Sonu0305 <[email protected]> | ||
|
||
TARDIS Bot <[email protected]> | ||
TARDIS Bot <[email protected]> tardis-bot <[email protected]> | ||
TARDIS Bot <[email protected]> TARDIS Bot <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import logging | ||
import numpy as np | ||
from astropy import units as u | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
def validate_radiative_temperature(t_radiative): | ||
""" | ||
Validates the radiative temperature to ensure it is physically reasonable. | ||
|
||
Parameters | ||
---------- | ||
t_radiative : Quantity | ||
The radiative temperature array. | ||
|
||
Raises | ||
------ | ||
ValueError | ||
If any radiative temperature is below 1000 K. | ||
""" | ||
if np.any(t_radiative < 1000 * u.K): | ||
min_t_rad = t_radiative[np.argmin(t_radiative)] | ||
min_shell = np.argmin(t_radiative) | ||
logging.critical( | ||
"Radiative temperature is too low in some of the shells, temperatures below 1000K " | ||
f"(e.g., T_rad = {min_t_rad} in shell {min_shell} in your model) " | ||
"are not accurately handled by TARDIS." | ||
) | ||
raise ValueError( | ||
f"Radiative temperature below 1000 K detected: T_rad = {min_t_rad} in shell {min_shell}." | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "validate_radiation_field" would be a better name