Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves time explosion off the transport solver to the transport state #2734

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jul 23, 2024

📝 Description

Fixes #2733

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.58%. Comparing base (38a35c3) to head (a2aba1d).

Files Patch % Lines
...transport/montecarlo/montecarlo_transport_state.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
- Coverage   36.58%   36.58%   -0.01%     
==========================================
  Files         186      186              
  Lines       14859    14860       +1     
==========================================
  Hits         5436     5436              
- Misses       9423     9424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wkerzendorf
Copy link
Member

well that was painless.

@wkerzendorf
Copy link
Member

@Rodot- can you review this?

Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@andrewfullard andrewfullard merged commit 375dd5b into tardis-sn:master Jul 25, 2024
14 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move time explosion to transport state
3 participants