Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cache Issues #2727

Merged
merged 7 commits into from
Jul 23, 2024
+4 −3
Merged

Fix Cache Issues #2727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d08425b
test commit
atharva-2001 Jul 23, 2024
f4a2d49
Change triggers temporarily
atharva-2001 Jul 23, 2024
80c3c1b
Should not contain the word merge
atharva-2001 Jul 23, 2024
9bccbaf
Fix typo
atharva-2001 Jul 23, 2024
42c90b3
Reset
atharva-2001 Jul 23, 2024
be67ef3
Empty commit
atharva-2001 Jul 23, 2024
3ca43e7
Fix typo
atharva-2001 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/actions/setup_lfs/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: "Setup LFS"
description: "Pull LFS repositories and caches them"


inputs:
refdata-repo:
description: "tardis refdata repository"
Expand Down Expand Up @@ -48,7 +49,7 @@ runs:
- name: Save LFS cache if not found
# uses fake ternary
# for reference: https://github.com/orgs/community/discussions/26738#discussioncomment-3253176
if: ${{ steps.lfs-cache-refdata.outputs.cache-hit != 'true' && always() || false }}
if: ${{ steps.lfs-cache-refdata.outputs.cache-hit != 'true' && !contains(github.ref, 'merge') && always() || false }}
uses: actions/cache/save@v4
id: lfs-cache-refdata-save
with:
Expand Down Expand Up @@ -88,7 +89,7 @@ runs:
- name: Save LFS cache if not found
# uses fake ternary
# for reference: https://github.com/orgs/community/discussions/26738#discussioncomment-3253176
if: ${{ steps.lfs-cache-regression-data.outputs.cache-hit != 'true' && always() || false }}
if: ${{ steps.lfs-cache-regression-data.outputs.cache-hit != 'true' && !contains(github.ref, 'merge') && always() || false }}
uses: actions/cache/save@v4
id: lfs-cache-regression-data-save
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
verbose: true

tests:
name: ${{ matrix.continuum }} continuum ${{ matrix.rpacket_tracking }} rpacket_tracking ${{ matrix.os }} ${{ inputs.pip_tests && 'pip tests enabled' || '' }}
name: ${{ matrix.continuum }} continuum ${{ matrix.rpacket_tracking }} rpacket_tracking ${{ matrix.os }} ${{ inputs.pip_git && 'pip tests enabled' || '' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was an error in the yml file which I'm afraid I didn't see. The job name will now say pip tests enabled if those tests are triggered by the pre release workflow. If not it will be as it is now.

if: github.repository_owner == 'tardis-sn'
runs-on: ${{ matrix.os }}
strategy:
Expand Down
Loading