Benchmark run_tardis with track_rpacket enabled #2720

Sumit112192 · 2024-07-22T09:36:10Z

📝 Description

Type: roller_coaster: infrastructure
This PR benchmarks the run_tardis function with track_rpacket enabled.

codecov · 2024-07-22T09:39:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (7231707) to head (6d702fa).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
- Coverage   69.86%   69.30%   -0.56%     
==========================================
  Files         192      192              
  Lines       15048    15048              
==========================================
- Hits        10513    10429      -84     
- Misses       4535     4619      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tardis-bot · 2024-07-22T13:35:03Z

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (7231707) and the latest commit (6d702fa).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

All benchmarks:

| Change   | Before [72317073] <master>   | After [6d702fa7]    | Ratio   | Benchmark (Parameter)                                                                                                                                                                                                                              |
|----------|------------------------------|---------------------|---------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
|          | 4.09±2μs                     | 2.85±1μs            | ~0.70   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000.0, 255.5)                                                                                                                                    |
|          | 3.18±1μs                     | 3.31±1μs            | 1.04    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000.0, 511.0)                                                                                                                                    |
|          | 3.65±1μs                     | 3.35±1μs            | 0.92    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000.0, 5110000000.0)                                                                                                                             |
|          | 4.00±2μs                     | 3.22±1μs            | ~0.81   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000000000.0, 255.5)                                                                                                                              |
|          | 3.50±1μs                     | 6.18±0.2μs          | ~1.77   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000000000.0, 511.0)                                                                                                                              |
|          | 3.43±1μs                     | 3.31±1μs            | 0.96    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000000000.0, 5110000000.0)                                                                                                                       |
|          | 4.40±2μs                     | 2.71±0.9μs          | ~0.62   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(1000000000000000.0, 255.5)                                                                                                                          |
|          | 3.89±1μs                     | 3.87±2μs            | 1.00    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(1000000000000000.0, 511.0)                                                                                                                          |
|          | 3.87±1μs                     | 3.10±1μs            | ~0.80   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(1000000000000000.0, 5110000000.0)                                                                                                                   |
|          | 3.54±1μs                     | 3.02±1μs            | ~0.85   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.0})                                                                        |
|          | 4.06±1μs                     | 3.21±1μs            | ~0.79   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.5})                                                                        |
|          | 4.08±1μs                     | 2.86±0.9μs          | ~0.70   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 511.0, 'Iron_group_fraction': 0.5})                                                                        |
|          | 4.19±2μs                     | 3.08±1μs            | ~0.73   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 5110000000.0, 'Iron_group_fraction': 0.0})                                                                 |
|          | 3.46±1μs                     | 3.03±1μs            | ~0.87   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 100000.0, 'Energy': 255.5, 'Iron_group_fraction': 1.0})                                                                    |
|          | 4.19±2μs                     | 2.80±0.9μs          | ~0.67   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.0})                                                                      |
|          | 4.31±2μs                     | 3.63±1μs            | ~0.84   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.5})                                                                      |
|          | 4.59±2μs                     | 3.07±1μs            | ~0.67   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 511.0, 'Iron_group_fraction': 0.5})                                                                      |
|          | 4.25±2μs                     | 2.91±0.9μs          | ~0.68   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 5110000000.0, 'Iron_group_fraction': 0.0})                                                               |
|          | 3.99±1μs                     | 3.76±1μs            | 0.94    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 100000.0, 'Energy': 255.5, 'Iron_group_fraction': 1.0})                                                                  |
|          | 1.52±0s                      | 1.50±0s             | 0.99    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                                                                                                                                  |
|          | 1.51±0.01s                   | 1.49±0s             | 0.99    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                                                                                                                                    |
|          | 42.0±0.2s                    | 41.4±0.2s           | 0.99    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                                                                                                                                      |
|          | 1.03±0m                      | 1.05±0m             | 1.01    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                                                                                                                                     |
|          | 2.14±0m                      | 2.15±0m             | 1.01    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                                                                                                                                |
|          | 4.89±2μs                     | 5.22±2μs            | 1.07    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body({'nu': 100000000000000.0, 'temperature': 10000.0})                                                                                                   |
|          | 62.5±10μs                    | 68.7±20μs           | 1.10    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                                                                                                                               |
|          | 78.0±20μs                    | 77.5±20μs           | 0.99    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line({'packet': {'nu_line': 0.1, 'is_last_line': True}, 'enable_full_relativity': True})                                               |
|          | 73.7±10μs                    | 86.6±20μs           | ~1.17   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line({'packet': {'nu_line': 0.2, 'is_last_line': False}, 'enable_full_relativity': True})                                              |
|          | 82.6±20μs                    | 86.8±20μs           | 1.05    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators({'cur_line_id': 0, 'distance_trace': 0, 'time_explosion': 52000000.0, 'enable_full_relativity': True})               |
|          | 85.2±20μs                    | 85.2±20μs           | 1.00    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators({'cur_line_id': 0, 'distance_trace': 1000000000000.0, 'time_explosion': 52000000.0, 'enable_full_relativity': True}) |
|          | 83.2±20μs                    | 89.2±20μs           | 1.07    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators({'cur_line_id': 1, 'distance_trace': 100000.0, 'time_explosion': 10000000000.0, 'enable_full_relativity': False})    |
|          | 7.69±0.03s                   | 8.22±0.02s          | 1.07    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission({'mu': 0.8599443103322428, 'emission_line_id': 1000, 'energy': 0.9114437898710559})                                                                    |
|          | 7.64±0.03s                   | 7.97±0s             | 1.04    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter(<LineInteractionType.MACROATOM: 2>)                                                                                                                     |
|          | 7.73±0.02s                   | 8.01±0.04s          | 1.04    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter(<LineInteractionType.SCATTER: 0>)                                                                                                                       |
|          | 3.63±0.06s                   | 3.65±0.01s          | 1.01    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                                                                                                                                      |
|          | 5.03±0.02s                   | 5.18±0.06s          | 1.03    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                                                                                                                                            |
|          | 25.5±8μs                     | 25.6±8μs            | 1.01    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(10)                                                                                                            |
|          | 37.5±10μs                    | 43.5±10μs           | ~1.16   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(100)                                                                                                           |
|          | 132±20μs                     | 172±40μs            | ~1.30   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(1000)                                                                                                          |
|          | 29.1±10μs                    | 30.9±10μs           | 1.06    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(1, 1)                                                                                                                           |
|          | 25.6±9μs                     | 29.7±10μs           | ~1.16   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(1, 10)                                                                                                                          |
|          | 29.0±10μs                    | 37.7±10μs           | ~1.30   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(1, 50)                                                                                                                          |
|          | 42.9±10μs                    | 44.1±10μs           | 1.03    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 1)                                                                                                                          |
|          | 43.8±10μs                    | 49.1±20μs           | ~1.12   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 10)                                                                                                                         |
|          | 50.1±20μs                    | 50.4±20μs           | 1.01    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 50)                                                                                                                         |
|          | 125±30μs                     | 111±30μs            | ~0.89   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(50, 1)                                                                                                                          |
|          | 114±30μs                     | 122±40μs            | 1.08    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(50, 10)                                                                                                                         |
|          | 98.5±20μs                    | 98.4±20μs           | 1.00    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(50, 50)                                                                                                                         |
|          | 1.40±0.01s                   | 1.51±0.01s          | 1.08    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                                                                                                                                 |
|          | 6.36±0.02s                   | 6.52±0.02s          | 1.03    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                                                                                                                                       |
|          | 5.09±0s                      | 5.09±0.02s          | 1.00    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                                                                                                                                      |
|          | 5.04±0.01s                   | 5.05±0.02s          | 1.00    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                                                                                                                                          |
|          | 5.01±0.03s                   | 5.05±0.01s          | 1.01    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley({'tau_russian': 10.0, 'survival_possibility': 0.0})                                                                                               |
|          | 5.00±0.01s                   | 5.08±0.01s          | 1.02    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley({'tau_russian': 15.0, 'survival_possibility': 0.1})                                                                                               |
|          | 3.57±0s                      | 3.78±0.03s          | 1.06    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                                                                                                                                             |

If you want to see the graph of the results, you can check it here

Sumit112192 · 2024-07-26T14:19:52Z

Will try a different way to implement benchmarks for RPacketTracker

tardis-bot · 2024-07-29T10:13:26Z

*beep* *bop*
Hi human,
I ran ruff on the latest commit (6d702fa).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Complete output(might be large):

Sumit112192 · 2024-07-29T10:16:53Z

benchmarks/benchmark_base.py

+        config = Configuration.from_yaml(
+            "tardis/io/configuration/tests/data/tardis_configv1_verysimple.yml"
+        )
+        config.montecarlo.tracking.track_rpacket = True


Only changing the track_rpacket to True and keeping everything else the same, so it can be checked how much the simulation takes extra with tracking enabled.

Can you change this function decorator to @functools.cached_property? You will need to import functools library.

Sumit112192 · 2024-07-29T17:59:34Z

@andrewfullard please review.

officialasishkumar · 2024-07-30T05:59:10Z

benchmarks/benchmark_base.py

@@ -239,7 +248,9 @@ def packet(self):

    @property
    def verysimple_packet_collection(self):
-        return self.nb_simulation_verysimple.transport.transport_state.packet_collection
+        return (
+            self.nb_simulation_verysimple.transport.transport_state.packet_collection


why are we returning in 3 lines?

These are changes suggested by black.

I think the formatter that is suggested to be used is ruff. I might be wrong.

cc: @andrewfullard

Ruff still needs to be implemented in TARDIS workflows.

officialasishkumar · 2024-07-30T06:47:26Z

LGTM

Sumit112192 · 2024-07-30T06:50:58Z

LGTM

Why is the benchmark on the master commit failing when I am using the cached property?

Sumit112192 · 2024-07-30T08:25:28Z

@officialasishkumar For now, I am removing the cached property decorator. You can work it out on your draft Pr after you rebase it.

officialasishkumar · 2024-07-30T08:26:27Z

Sure

officialasishkumar

LGTM

#77) * added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]>

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]>

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> * fix me Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]>

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> * fix error in formal integral Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]>

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> * fix error in formal integral Signed-off-by: Asish Kumar <[email protected]> * more cache Signed-off-by: Asish Kumar <[email protected]> * sort by ratio Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]>

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> * fix error in formal integral Signed-off-by: Asish Kumar <[email protected]> * more cache Signed-off-by: Asish Kumar <[email protected]> * sort by ratio Signed-off-by: Asish Kumar <[email protected]> * cache in setup function Signed-off-by: Asish Kumar <[email protected]> * changes to me Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]>

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> * fix error in formal integral Signed-off-by: Asish Kumar <[email protected]> * more cache Signed-off-by: Asish Kumar <[email protected]> * sort by ratio Signed-off-by: Asish Kumar <[email protected]> * Donot run docs, benchmarks and stardis tests on draft PRs. (tardis-sn#2761) * Add ready to review to run tests * Add if condition to check PR status * Running stardis tests only on push to master * Removing osx-64 from workflows * Add Extend Array Function (tardis-sn#2771) * Add Extend Array Function * Fix Typo and restructure * Restructure * Doc string update * Was expecting numpy arrays to be passed by reference but it is not so updating it * Add test for the extend array function * Opacity state slice (tardis-sn#2758) * Added basic sliing operation to opacitystate and set the transport solver to use the bounds of the gemoetry indices * Reformatted the slicing index * Added slicing operation with __getitem__ * Added docstring * removed old slice method * Ran black * Added back the 'slice' method because __getitem__ is wacky * added missing argument * fixed missing argument * ran black * fixed the tests * ran black * Updated the slice to use __getitem__ again and modified the opacitystate object defined in the opacities module * Removed old slice method and print statements * removed print statement from the test * added type annotation to OpacityState getitem * updated numba interface * Fixes black formatting * Release Pipeline Fixes (tardis-sn#2767) * Fix zenodo badge * Pick from the website * update badge in credits.rst * Use the all versions DOI * Inherit secrets * Change triggers for testing * Reset Triggers * Fix ruff comments issue (tardis-sn#2762) * Fix ruff comments issue * Only check files changed * Testing triggers * Fix bash commands * No pager * fetch depth * Reset all changes * cache in setup function Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]> Co-authored-by: KasukabeDefenceForce <[email protected]> Co-authored-by: Jack O'Brien <[email protected]> Co-authored-by: Andrew Fullard <[email protected]> Co-authored-by: Atharva Arya <[email protected]>

atharva-2001 added the benchmarks label Jul 22, 2024

Sumit112192 marked this pull request as ready for review July 22, 2024 13:54

Sumit112192 marked this pull request as draft July 22, 2024 14:18

Sumit112192 closed this Jul 26, 2024

Sumit112192 reopened this Jul 29, 2024

Sumit112192 commented Jul 29, 2024

View reviewed changes

Sumit112192 marked this pull request as ready for review July 29, 2024 10:18

Sumit112192 force-pushed the BenchmarkRPacketTracker branch from 2aaff83 to aec66d7 Compare July 29, 2024 13:38

andrewfullard previously approved these changes Jul 29, 2024

View reviewed changes

andrewfullard requested a review from officialasishkumar July 29, 2024 19:29

Sumit112192 dismissed andrewfullard’s stale review via e5c4fc7 July 30, 2024 05:45

officialasishkumar reviewed Jul 30, 2024

View reviewed changes

Sumit112192 added 5 commits July 30, 2024 15:43

Benchmark run_tardis with track_rpacket enabled

06471f3

Update config to resemble time_run_tardis config

8929792

Fix Benchmark error

10c2d43

Cache Benchmark Property

8ffd426

Remove Cached Property decorator

6d702fa

Sumit112192 force-pushed the BenchmarkRPacketTracker branch from 12115f7 to 6d702fa Compare July 30, 2024 10:13

andrewfullard approved these changes Jul 30, 2024

View reviewed changes

andrewfullard requested a review from officialasishkumar July 30, 2024 13:32

officialasishkumar approved these changes Jul 31, 2024

View reviewed changes

andrewfullard merged commit c57d74d into tardis-sn:master Jul 31, 2024
17 of 18 checks passed

Sumit112192 deleted the BenchmarkRPacketTracker branch September 8, 2024 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Benchmark run_tardis with track_rpacket enabled #2720

Benchmark run_tardis with track_rpacket enabled #2720

Sumit112192 commented Jul 22, 2024

codecov bot commented Jul 22, 2024 •

edited

Loading

tardis-bot commented Jul 22, 2024 •

edited

Loading

Sumit112192 commented Jul 26, 2024

tardis-bot commented Jul 29, 2024 •

edited

Loading

Sumit112192 Jul 29, 2024 •

edited

Loading

officialasishkumar Jul 30, 2024

Sumit112192 Jul 30, 2024

Sumit112192 commented Jul 29, 2024

officialasishkumar Jul 30, 2024

Sumit112192 Jul 30, 2024

officialasishkumar Jul 30, 2024

Sumit112192 Jul 30, 2024

officialasishkumar commented Jul 30, 2024

Sumit112192 commented Jul 30, 2024

Sumit112192 commented Jul 30, 2024

officialasishkumar commented Jul 30, 2024

officialasishkumar left a comment

Benchmark run_tardis with track_rpacket enabled #2720

Benchmark run_tardis with track_rpacket enabled #2720

Conversation

Sumit112192 commented Jul 22, 2024

📝 Description

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

tardis-bot commented Jul 22, 2024 • edited Loading

Sumit112192 commented Jul 26, 2024

tardis-bot commented Jul 29, 2024 • edited Loading

Sumit112192 Jul 29, 2024 • edited Loading

Choose a reason for hiding this comment

officialasishkumar Jul 30, 2024

Choose a reason for hiding this comment

Sumit112192 Jul 30, 2024

Choose a reason for hiding this comment

Sumit112192 commented Jul 29, 2024

officialasishkumar Jul 30, 2024

Choose a reason for hiding this comment

Sumit112192 Jul 30, 2024

Choose a reason for hiding this comment

officialasishkumar Jul 30, 2024

Choose a reason for hiding this comment

Sumit112192 Jul 30, 2024

Choose a reason for hiding this comment

officialasishkumar commented Jul 30, 2024

Sumit112192 commented Jul 30, 2024

Sumit112192 commented Jul 30, 2024

officialasishkumar commented Jul 30, 2024

officialasishkumar left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 22, 2024 •

edited

Loading

tardis-bot commented Jul 22, 2024 •

edited

Loading

tardis-bot commented Jul 29, 2024 •

edited

Loading

Sumit112192 Jul 29, 2024 •

edited

Loading