Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setup environment steps to composite action #2698

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Jul 11, 2024

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

The setup environment steps are redundant across all workflows and can be moved to a separate composite action file. This will make it easy to users to create new workflows and make them simpler.

📌 Resources

Examples, notebooks, and links to useful references.
Tests worked fine with the new setup.
https://github.com/tardis-sn/tardis/actions/runs/9889637912/job/27317780010

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 marked this pull request as draft July 11, 2024 10:15
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@atharva-2001 atharva-2001 marked this pull request as ready for review July 11, 2024 14:43
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less duplication, yay

atharva-2001 added a commit to atharva-2001/tardis that referenced this pull request Jul 12, 2024
Test moving setup environment steps to composite action file

Replace steps with action in other docs pre release and update refdata
@atharva-2001 atharva-2001 mentioned this pull request Jul 12, 2024
6 tasks
@andrewfullard andrewfullard merged commit 5d22754 into tardis-sn:master Jul 12, 2024
13 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants