Change setup.cfg to pyproject.toml #2694
Conversation
|
*beep* *bop* Hi, human. The Click here to see your results. |
setup.cfg
Outdated
| @@ -88,4 +88,4 @@ exclude_lines = | |||
| [options.entry_points] | |||
| console_scripts = | |||
There was a problem hiding this comment.
In the end, we want to remove setup.cfg
You want to remove this and then make sure the tests pass.
There was a problem hiding this comment.
also I will suggest adding some reference links in the pr description on why we're switching from setup.cfg to pyproject.toml
There was a problem hiding this comment.
on a side note, we also want to perhaps remove setup.py- these files are outdated and python community has better ways for packaging if you could research it would be great.
pyproject.toml
Outdated
| dynamic = ["version"] | ||
|
|
||
| [project.optional-dependencies] | ||
| test = ['pytest-astropy'] |
There was a problem hiding this comment.
Use double quotes consistently
pyproject.toml
Outdated
|
|
||
| [tool.pytest.ini_options] | ||
| testpaths = ["tardis"] | ||
| # astropy_header = true |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
The tests were failing after I added those two lines so I was testing which is exactly causing the tests to fail.
pyproject.toml
Outdated
| [tool.pytest.ini_options] | ||
| testpaths = ["tardis"] | ||
| # astropy_header = true | ||
| # doctest_plus = "disabled" |
There was a problem hiding this comment.
Why are we keeping a commented out line?
📝 Description
Type: 🎢
infrastructureThis PR aims at shifting all the configurations from the setup.cfg to pyproject.toml.
📌 Resources
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel