I/O Refactoring #2652
I/O Refactoring #2652
Conversation
_from_config and _from_csvy to match typical class methods Config first, CSVY second
With small extensions outside that area
|
What really needs to happen to resolve the CSVY bug (and may happen in this PR?) is to remove all |
Should fix read/write issue.
Not really happy with it, but helps show some of the current problems with the config arrangement compared to the code
Also adjusts notebook to deal with quantity-based packet frequencies
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
*beep* *bop* Hi, human. The Click here to see your results. |
|
@jvshields pluralized instances of mass_fraction in this PR. The Composition class still has lots of singular form. |
| type: | ||
| type: string | ||
| default: 'damped' | ||
| description: THIS IS A DUMMY VARIABLE DO NOT USE |
There was a problem hiding this comment.
It is for now until the config is restructured
|
|
||
| Returns | ||
| ------- | ||
| DiluteThermalRadiationFieldState |
There was a problem hiding this comment.
that needs to change at some stage to Planckian
|
|
||
| Returns | ||
| ------- | ||
| DiluteThermalRadiationFieldState |
| filename or path of the density file | ||
| abundance_filetype : str | ||
| mass_fractions_filetype : str |
| @@ -0,0 +1,91 @@ | |||
| from tardis.io.model.readers.util import read_csv_isotope_mass_fractions | |||
There was a problem hiding this comment.
do we know what's going on with this file?
There was a problem hiding this comment.
It's the old reader, it actually produces a result but it's deprecated. We can clean it out once we are happy the new reader works as intended.
andrewfullard
dismissed stale reviews from wkerzendorf and jvshields
via
05805df
📝 Description
Type: 🎢
infrastructureThis PR refactors the I/O part of TARDIS to split it up better by category e.g. Composition (and its parts).
Also fixes bug with CSVY dimensions
Fixes #2582
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel