Refactor and add more benchmarks for montecarlo #2640

officialasishkumar · 2024-06-02T11:06:49Z

📝 Description

Type: 🚀 feature

Refactor montecarlo Bencmarks and adding new benchmarks that cover most of the functions inside montecarlo.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Signed-off-by: Asish Kumar <[email protected]>

tardis-bot · 2024-06-02T11:07:48Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot · 2024-06-02T11:08:26Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

Signed-off-by: Asish Kumar <[email protected]>

tardis-bot · 2024-06-02T14:01:19Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

Signed-off-by: Asish Kumar <[email protected]>

tardis-bot · 2024-06-03T11:09:44Z

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (e88a31a) and the latest commit (a245a7d).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

· No results found

All benchmarks:

· No results found

Signed-off-by: Asish Kumar <[email protected]>

AlexHls · 2024-06-06T13:36:19Z

@officialasishkumar Can you please update the PR description, adding some details and a description of your changes?

Signed-off-by: Asish Kumar <[email protected]>

atharva-2001 · 2024-07-01T14:14:20Z

benchmarks/run_tardis.py


    def time_run_tardis(self):
-        run_tardis(self.config, log_level="ERROR", show_progress_bars=False)
+        run_tardis(self.path, log_level="ERROR", show_progress_bars=False)


There should be an empty line at the end of the file.

atharva-2001 · 2024-07-01T14:15:45Z

benchmarks/transport_montecarlo_main_loop.py

+
+class BenchmarkTransportMontecarloMainLoop(BenchmarkBase):
+    """
+    class to benchmark montecarlo_main_loop


Sorry for being too nit-picky, this can be improved.

I'm not sure in what sense. Can you please elaborate more?

I think Atharva would like a more descriptive docstring

atharva-2001 · 2024-07-01T14:17:31Z

benchmarks/transport_montecarlo_opacities.py

+        }
+    )
+    def time_kappa_calculation(self, energy):
+        calculate_opacity.kappa_calculation(energy)


Empty line at end of file

https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no-newline-at-end-of-file-log

Is there any vs code extension to automate this task?

benchmarks/transport_montecarlo_numba_formal_integral_p.py

atharva-2001 · 2024-07-01T14:26:36Z

benchmarks/transport_montecarlo_numba_formal_integral_p.py

-                assert actual == 0
-            else:
-                np.sqrt(r * r - p * p) * formal_integral.C_INV * inv_t
+            func(r, p, inv_t)

    @skip_benchmark
    @parameterize({"p": [0, 0.5, 1], "Test data": TESTDATA})


Small question, how does "Test data" know to send its value to test_data?

it sends data sequence wise. Parameter name is nothing to do with it.

benchmarks/transport_montecarlo_numba_formal_integral_p.py

Signed-off-by: Asish Kumar <[email protected]>

codecov · 2024-07-11T07:27:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (0df98ce) to head (ea6175a).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2640      +/-   ##
==========================================
+ Coverage   67.80%   69.67%   +1.87%     
==========================================
  Files         177      181       +4     
  Lines       14534    14468      -66     
==========================================
+ Hits         9855    10081     +226     
+ Misses       4679     4387     -292

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar · 2024-07-11T16:11:21Z

command: asv run refactor-benchmarks^!
Output: https://paste.opensuse.org/pastes/bbf48b94a74c

the benchmarks are ran on all the functions in this PR.

andrewfullard

Good work. Please address any remaining comments!

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar · 2024-07-12T13:39:02Z

Benchmark results for formal_integral functions: https://paste.opensuse.org/pastes/4983e0ca50cb

DeerWhale · 2024-07-12T14:14:58Z

benchmarks/benchmark_base.py

+
+    @property
+    def simulation_rpacket_tracking_enabled(self):
+        config_verysimple = self.config_verysimple


(Can be future work) Setting up a separate config property or a yml file is cleaner.

officialasishkumar added 3 commits May 31, 2024 14:57

benchmark for energy input package

d61d905

Signed-off-by: Asish Kumar <[email protected]>

refactor benchmark - remove assert

1664b38

Signed-off-by: Asish Kumar <[email protected]>

remove energy input source

d40cfea

Signed-off-by: Asish Kumar <[email protected]>

intensity_black_body and test_reverse_binary_search function benchmark

bd9a8f6

Signed-off-by: Asish Kumar <[email protected]>

add name and email in .mailmap

75e2b0e

Signed-off-by: Asish Kumar <[email protected]>

atharva-2001 requested review from andrewfullard, atharva-2001 and AlexHls June 3, 2024 11:08

atharva-2001 added the benchmarks label Jun 3, 2024

officialasishkumar added 7 commits June 3, 2024 18:48

fix import error of Configuration

ab13842

Signed-off-by: Asish Kumar <[email protected]>

refactor transport_montecarlo_packet.py

4c86741

Signed-off-by: Asish Kumar <[email protected]>

refactor transport_montecarlo_numba_formal_integral_p.py

f5ebda4

Signed-off-by: Asish Kumar <[email protected]>

add FormalIntegrator benchmark

48d164d

Signed-off-by: Asish Kumar <[email protected]>

add calculate_spectrum benchmark

edc5dce

Signed-off-by: Asish Kumar <[email protected]>

add make_source_function and generate_numba_objects in benchmark

4a909f0

Signed-off-by: Asish Kumar <[email protected]>

add formal_integral from FormalIntegrator class benchmark

76cb1cf

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar marked this pull request as draft June 6, 2024 13:34

officialasishkumar changed the title ~~[WIP] Refactor benchmarks~~ [WIP] Refactor and add more benchmarks for montecarlo Jun 8, 2024

officialasishkumar added 7 commits June 17, 2024 19:34

add trace_vpacket_volley benchmark

247add4

Signed-off-by: Asish Kumar <[email protected]>

add single_packet_loop benchmark

8c2fa52

Signed-off-by: Asish Kumar <[email protected]>

refactor vpacket benchmark

4974f89

Signed-off-by: Asish Kumar <[email protected]>

refactor r_packet benchmark

e3d52ba

Signed-off-by: Asish Kumar <[email protected]>

add montecarlo_main_loop benchmark

293d183

Signed-off-by: Asish Kumar <[email protected]>

refactor VPacketCollection_add_packet benchmark

b4e01ce

Signed-off-by: Asish Kumar <[email protected]>

refactor transport_montecarlo_packet.py

70119f4

Signed-off-by: Asish Kumar <[email protected]>

atharva-2001 reviewed Jul 1, 2024

View reviewed changes

benchmarks/transport_montecarlo_numba_formal_integral_p.py Outdated Show resolved Hide resolved

atharva-2001 reviewed Jul 1, 2024

View reviewed changes

DeerWhale reviewed Jul 1, 2024

View reviewed changes

benchmarks/transport_montecarlo_numba_formal_integral_p.py Show resolved Hide resolved

skip benchmark with GNU error

a245a7d

officialasishkumar force-pushed the refactor-benchmarks branch from bc2628e to a245a7d Compare July 2, 2024 07:53

andrewfullard mentioned this pull request Jul 3, 2024

fix benchmark action #2656

Merged

6 tasks

andrewfullard self-requested a review July 9, 2024 13:16

officialasishkumar force-pushed the refactor-benchmarks branch 3 times, most recently from b2926ad to c1e4c2f Compare July 9, 2024 14:15

benchmark single packet loop

09e3032

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar force-pushed the refactor-benchmarks branch from c1e4c2f to 09e3032 Compare July 9, 2024 14:18

fix benchmark trace_vpacket_volley

ea6175a

Signed-off-by: Asish Kumar <[email protected]>

fix benchmark single_packet_loop

5bae9d4

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar force-pushed the refactor-benchmarks branch from 953168a to 5bae9d4 Compare July 11, 2024 07:38

andrewfullard previously approved these changes Jul 11, 2024

View reviewed changes

change docstring

72340d1

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar requested a review from atharva-2001 July 12, 2024 13:14

officialasishkumar dismissed andrewfullard’s stale review via 72340d1 July 12, 2024 13:14

officialasishkumar requested a review from DeerWhale July 12, 2024 13:16

fix benchmark formal_integral functions

fbae4cc

Signed-off-by: Asish Kumar <[email protected]>

officialasishkumar force-pushed the refactor-benchmarks branch from dc4aa62 to fbae4cc Compare July 12, 2024 13:38

DeerWhale reviewed Jul 12, 2024

View reviewed changes

andrewfullard approved these changes Jul 12, 2024

View reviewed changes

DeerWhale approved these changes Jul 12, 2024

View reviewed changes

andrewfullard merged commit 17b1da4 into tardis-sn:master Jul 12, 2024
7 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor and add more benchmarks for montecarlo #2640

Refactor and add more benchmarks for montecarlo #2640

officialasishkumar commented Jun 2, 2024 •

edited

Loading

tardis-bot commented Jun 2, 2024

tardis-bot commented Jun 2, 2024

tardis-bot commented Jun 2, 2024

tardis-bot commented Jun 3, 2024 •

edited

Loading

AlexHls commented Jun 6, 2024

atharva-2001 Jul 1, 2024

atharva-2001 Jul 1, 2024

officialasishkumar Jul 11, 2024

andrewfullard Jul 11, 2024

atharva-2001 Jul 1, 2024

atharva-2001 Jul 1, 2024

officialasishkumar Jul 8, 2024

atharva-2001 Jul 1, 2024

officialasishkumar Jul 11, 2024

codecov bot commented Jul 11, 2024

officialasishkumar commented Jul 11, 2024

andrewfullard left a comment

officialasishkumar commented Jul 12, 2024

DeerWhale Jul 12, 2024

Refactor and add more benchmarks for montecarlo #2640

Refactor and add more benchmarks for montecarlo #2640

Conversation

officialasishkumar commented Jun 2, 2024 • edited Loading

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

tardis-bot commented Jun 2, 2024

tardis-bot commented Jun 2, 2024

tardis-bot commented Jun 2, 2024

tardis-bot commented Jun 3, 2024 • edited Loading

AlexHls commented Jun 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 11, 2024

Codecov Report

officialasishkumar commented Jul 11, 2024

andrewfullard left a comment

Choose a reason for hiding this comment

officialasishkumar commented Jul 12, 2024

Choose a reason for hiding this comment

officialasishkumar commented Jun 2, 2024 •

edited

Loading

tardis-bot commented Jun 3, 2024 •

edited

Loading