Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes IntegrationError causing refdata generation failure #2595

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Fixes IntegrationError causing refdata generation failure #2595

merged 3 commits into from
Apr 22, 2024

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Apr 22, 2024 •
edited
Loading

Now returns an empty spectrum instead of a crash and gives a warning.

📝 Description

Type: 🪲 bugfix

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@andrewfullard
Fixes IntegrationError causing refdata generation failure
93d7a3b 
Now returns an empty spectrum instead of a crash and gives a warning.
@andrewfullard andrewfullard merged commit 0cb3107 into tardis-sn:master Apr 22, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atharva-2001 atharva-2001 Awaiting requested review from atharva-2001

@wkerzendorf wkerzendorf Awaiting requested review from wkerzendorf

Assignees
No one assigned
Labels
bugfix 🪲
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewfullard