Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated helium nlte page in docs with in-text citation #2574

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

erinvisser
Copy link
Contributor

📝 Description

Type: 📝 documentation

The Helium NLTE docs page had a line referring to information "in an upcoming paper," but that paper came out in 2017. I added the paper to the list of references and replaced "in an upcoming paper" with an in-text citation.

📌 Resources

Screenshot 2024-04-04 at 5 25 47 PM Screenshot 2024-04-04 at 5 26 25 PM

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.51%. Comparing base (763f571) to head (a026895).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2574   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         170      170           
  Lines       14230    14230           
=======================================
  Hits         9608     9608           
  Misses       4622     4622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard merged commit caff982 into tardis-sn:master Apr 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants