Path.replace bug

.mailmap

@@ -263,3 +263,5 @@ Sarthak Srivastava <[email protected]> Sarthak Srivastava <sarthaksri592@g
 
 Kim Lingemann <[email protected]> kimsina <[email protected]>
 Kim Lingemann <[email protected]> kim <[email protected]>
+
+Sumit Gupta <[email protected]>

tardis/io/atom_data/base.py

@@ -164,7 +164,7 @@ def from_hdf(cls, fname=None):
 
         Parameters
         ----------
-        fname : str, optional
+        fname : Path, optional
             Path to the HDFStore file or name of known atom data file
             (default: None)
         """

tardis/io/atom_data/util.py

@@ -1,5 +1,6 @@
 import os
 import logging
+from pathlib import Path
 
 from tardis.io.configuration.config_internal import get_data_dir
 from tardis.io.atom_data.atom_web_download import (
@@ -16,26 +17,28 @@
 
     Parameters
     ----------
-    fname : str
+    fname : Path
         name or path of atom data HDF file
 
     Returns
     -------
-        : str
+        : Path
         resolved fpath
     """
 
+    fname = Path(fname)
     if os.path.exists(fname):
         return fname
 
-    fpath = os.path.join(os.path.join(get_data_dir(), fname))
+    fname = Path(fname.stem).with_suffix(".h5")
+    fpath = Path(os.path.join(get_data_dir(), fname))
     if os.path.exists(fpath):
         logger.info(
             f"\n\tAtom Data {fname} not found in local path.\n\tExists in TARDIS Data repo {fpath}"
         )
         return fpath
 
-    atom_data_name = fname.replace(".h5", "")
+    atom_data_name = fname.stem
     atom_repo_config = get_atomic_repo_config()
     if atom_data_name in atom_repo_config:
         raise IOError(

tardis/simulation/base.py

@@ -667,7 +667,7 @@ def from_config(
         if atom_data is None:
             if "atom_data" in config:
                 if Path(config.atom_data).is_absolute():
-                    atom_data_fname = config.atom_data
+                    atom_data_fname = Path(config.atom_data)
                 else:
                     atom_data_fname = (
                         Path(config.config_dirname) / config.atom_data