-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui.py and running.rst edited for PyQt4 and PySide #251
gui.py and running.rst edited for PyQt4 and PySide #251
Conversation
gui.py will now import PyQt4 or PySide depending on which is available and chosen (see documentation). So it is compatible with both bindings now. Details on how to choose a binding is added in running.rst.
I don't understand what the coverage decreased means. Can someone help me? |
@gautam1168, Coverage decreased means that the percentage of lines of code that are currently being tested/covered by the tests has decreased |
because you added additional lines do the code, that are not tested. The GUI is difficult to test, so do not worry about it (i think we can handle 0.04%). |
@gautam1168 so it works for pyqt4 and pyside? |
Yes as I have written in the running.rst step 2, one can choose between PySide and PyQt4 by setting/unsetting the environment variable QT_API in bash before launching the ipython shell. |
I understand, did you try it with an environment with pyside and one with pyqt4 |
No, one doesn't need to keep only one package in the environment. One can have both PySide and PyQt4 and choose between the two. Then after launching the ipython shell one can check which one
But I will try it out with environments that have only one of them installed and let you know. |
@gautam1168 good work! |
Hold on, don't merge it yet. I think something has broken. I cannot execute run_tardis. Let me fix this and check those environments. I'll try to sort all of this out by midnight today. |
It all works. It is ready for merging. I created two clones of my environment and removed pyqt from one and pyside from the other. Then I ran the gui in each after setting/unsetting QT_API as required. And it works in both cases as well as in the environment that has both the bindings. |
gui.py and running.rst edited for PyQt4 and PySide
gui.py will now import PyQt4 or PySide depending on which is available and chosen (see documentation). So it is compatible with both bindings now.
Details on how to choose a binding is added in running.rst.