Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numba parallel issues #2447

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Fix numba parallel issues #2447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fbc76f
Enabled parallel
AlexHls Oct 16, 2023
d367d03
Fix the mistake
AlexHls Oct 16, 2023
4d6226e
Update docs
AlexHls Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions docs/io/configuration/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ The necessary parameters for a TARDIS simulation are provided via a `YAML <https
configuration file. The following sections respectively describes what can or must be included in the
configuration file, shows an example configuration file, describes how TARDIS checks to make sure a configuration
file is valid, and demonstrates how a YAML configuration file is read in.

.. caution::
TARDIS parallelization is not working correctly at the moment and might produce incorrect results.
Please avoid using it.
For more information, see issue `#2021 <https://github.com/tardis-sn/tardis/issues/2021>`_.

.. toctree::
:maxdepth: 1
Expand Down
16 changes: 0 additions & 16 deletions docs/quickstart.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,22 +56,6 @@
"The configuration file [tardis_example.yml](https://github.com/tardis-sn/tardis/tree/master/docs/tardis_example.yml) is used throughout this Quickstart."
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
"<div class=\"alert alert-warning\">\n",
"\n",
"**Warning:**\n",
"\n",
"TARDIS parallelization is not working correctly at the moment and might produce incorrect results.\n",
"Please avoid using it.\n",
"For more information, see issue [#2021](https://github.com/tardis-sn/tardis/issues/2021).\n",
"\n",
"</div>\n"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down
6 changes: 0 additions & 6 deletions tardis/montecarlo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,6 @@ def __init__(

# Set number of threads
self.nthreads = nthreads
if self.nthreads != 1:
raise ValueError(
"""TARDIS parallelization is not working correctly at the moment and is hence disabled.
Please see issue https://github.com/tardis-sn/tardis/issues/2021.
"""
)

# set up logger based on config
mc_tracker.DEBUG_MODE = debug_packets
Expand Down
2 changes: 1 addition & 1 deletion tardis/montecarlo/montecarlo_numba/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def montecarlo_main_loop(
numba_radial_1d_geometry,
numba_model,
opacity_state,
estimators,
local_estimators,
vpacket_collection,
rpacket_tracker,
)
Expand Down
Loading