Reading fully ionized species with species_string_to_tuple

[sonachitchyan]

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

species_string_to_tuple can't read species where ion number is equal to atomic number (screenshot below). This PR fixes that

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

• Testing pipeline
• Other method (describe)
• My changes can't be tested (explain why)

☑️ Checklist

• I requested two reviewers for this pull request
• I updated the documentation according to my changes
• I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

[andrewfullard]

Hilarious bug, good find

[codecov]

Codecov Report

Merging #2403 (8f6abcd) into master (59bdcf3) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 66.66%.

❗ Current head 8f6abcd differs from pull request most recent head 7a11cd4. Consider uploading reports for the commit 7a11cd4 to get more accurate results

@@            Coverage Diff             @@
##           master    #2403      +/-   ##
==========================================
- Coverage   68.49%   68.49%   -0.01%     
==========================================
  Files         145      145              
  Lines       13245    13247       +2     
==========================================
+ Hits         9072     9073       +1     
- Misses       4173     4174       +1     

Files Changed	Coverage Δ
tardis/montecarlo/base.py	87.28% <50.00%> (-0.32%)	⬇️
tardis/util/base.py	73.07% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonachitchyan]

Can't be auto-merged because of osx tests? @andrewfullard

[andrewfullard]

Yep, trying to fix.