Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__.py in radiation_field subpackage #2400

Merged

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚦 testing | 🎢 infrastructure

This should fix the failing benchmarks workflow.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
    Testing this on my master.
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (f80812b) and the latest commit (0cbc7aa).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

All benchmarks:

All benchmarks:

     before           after         ratio
   [f80812b9]       [0cbc7aa7]
         failed         744±10ms      n/a  benchmark_run_tardis.Benchmarkruntardis.time_run_tardis

@atharva-2001 atharva-2001 marked this pull request as ready for review August 21, 2023 12:09
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2400 (e602d6b) into master (f80812b) will not change coverage.
The diff coverage is n/a.

❗ Current head e602d6b differs from pull request most recent head 0cbc7aa. Consider uploading reports for the commit 0cbc7aa to get more accurate results

@@           Coverage Diff           @@
##           master    #2400   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files         145      145           
  Lines       13245    13245           
=======================================
  Hits         9072     9072           
  Misses       4173     4173           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrewfullard andrewfullard merged commit e444787 into tardis-sn:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants