Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about the parallelization problem #2399

Merged

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 📝 documentation

Related to #2021.
Updates the quickstart and configuration index page.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2399 (c85ab5e) into master (f80812b) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head c85ab5e differs from pull request most recent head 438f76b. Consider uploading reports for the commit 438f76b to get more accurate results

@@           Coverage Diff           @@
##           master    #2399   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files         145      145           
  Lines       13245    13245           
=======================================
  Hits         9072     9072           
  Misses       4173     4173           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 21, 2023

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

andrewfullard
andrewfullard previously approved these changes Aug 21, 2023
@atharva-2001
Copy link
Member Author

atharva-2001 commented Aug 21, 2023 via email

@andrewfullard
Copy link
Contributor

Danger box show up in configuration input. I would actually like to see that on the front page of the docs, not config input.

The warning in the notebook is just plain text.

@andrewfullard andrewfullard self-requested a review August 21, 2023 12:33
@atharva-2001 atharva-2001 marked this pull request as ready for review August 22, 2023 13:27
@atharva-2001 atharva-2001 enabled auto-merge (squash) August 22, 2023 13:27
@atharva-2001 atharva-2001 merged commit 59bdcf3 into tardis-sn:master Aug 22, 2023
@atharva-2001 atharva-2001 mentioned this pull request Aug 25, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants