Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hardcoding of RPacket radius #2381

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

xansh
Copy link
Member

@xansh xansh commented Aug 3, 2023

📝 Description

Type: 🪲 bugfix | 🎢 infrastructure

Inside montecarlo_main_loop, the inner boundary radius was being enforced during r_packet creation. Instead, it should use the radius selected by PacketSource

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@xansh xansh self-assigned this Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2381 (7c17377) into master (5b36105) will not change coverage.
The diff coverage is n/a.

❗ Current head 7c17377 differs from pull request most recent head 817d650. Consider uploading reports for the commit 817d650 to get more accurate results

@@           Coverage Diff           @@
##           master    #2381   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files         139      139           
  Lines       12875    12875           
=======================================
  Hits         9087     9087           
  Misses       3788     3788           
Files Changed Coverage Δ
tardis/montecarlo/montecarlo_numba/base.py 32.53% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wkerzendorf wkerzendorf merged commit 3d4eebb into tardis-sn:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants