Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init.py to energy input module #2376

Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jul 31, 2023

📝 Description

Type: 🪲 bugfix

Hopefully fixes the Conda feedstock, and issue #2370

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2376 (3d99b0a) into master (5b36105) will decrease coverage by 2.07%.
The diff coverage is n/a.

❗ Current head 3d99b0a differs from pull request most recent head 0533d2e. Consider uploading reports for the commit 0533d2e to get more accurate results

@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
- Coverage   70.57%   68.50%   -2.07%     
==========================================
  Files         139      144       +5     
  Lines       12875    13264     +389     
==========================================
  Hits         9087     9087              
- Misses       3788     4177     +389     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epassaro
Copy link
Member

Do montecarlo_/montecarlo_numba need init files too? https://github.com/tardis-sn/tardis/pull/2139/files

@andrewfullard
Copy link
Contributor Author

Do montecarlo_/montecarlo_numba need init files too? https://github.com/tardis-sn/tardis/pull/2139/files

They already have them.

@andrewfullard
Copy link
Contributor Author

Unfortunately this does not seem to fix the benchmarks.

@epassaro
Copy link
Member

epassaro commented Aug 1, 2023

Do montecarlo_/montecarlo_numba need init files too? https://github.com/tardis-sn/tardis/pull/2139/files

They already have them.

I think init file is missing here: https://github.com/tardis-sn/tardis/tree/master/tardis/montecarlo/montecarlo_numba/tests

@atharva-2001 atharva-2001 merged commit 97a78ba into tardis-sn:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants