Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch Compare Refdata Event to Refdata Repo #2335

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

atharva-2001
Copy link
Member

📝 Description

🚦 testing 🎢 infrastructure
The command /compare-refdata doesn't work because the current workflow dispatches events only to the TARDIS repo. This change adds another step to trigger the compare-refdata workflow command in the refdata repo.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2335 (357b77e) into master (b11ace7) will not change coverage.
The diff coverage is n/a.

❗ Current head 357b77e differs from pull request most recent head fcdc7b6. Consider uploading reports for the commit fcdc7b6 to get more accurate results

@@           Coverage Diff           @@
##           master    #2335   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files         137      137           
  Lines       12516    12516           
=======================================
  Hits         9008     9008           
  Misses       3508     3508           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atharva-2001 atharva-2001 requested a review from xansh June 20, 2023 10:44
Copy link
Member

@xansh xansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this. Going forward maybe we can figure out a way to avoid duplication of other fields (as only the commands fields is different, rest all are duplicated)

@andrewfullard andrewfullard enabled auto-merge (squash) June 29, 2023 18:27
@andrewfullard andrewfullard disabled auto-merge June 29, 2023 19:37
@andrewfullard andrewfullard enabled auto-merge (squash) June 29, 2023 19:37
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard andrewfullard merged commit 8d34ffd into tardis-sn:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants