Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks Push To Repo Bug Fix #2330

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Benchmarks Push To Repo Bug Fix #2330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee3ec7
Delete env files
atharva-2001 Jun 16, 2023
b417798
Change issue number
atharva-2001 Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Install asv
run: pip install asv==0.5.*

- name: Accpet all asv questions
- name: Accept all asv questions
run: asv machine --yes

- name: Run benchmarks for last 5 commits if not PR
Expand All @@ -73,6 +73,10 @@ jobs:
if: github.event_name != 'pull_request'
run: asv publish

- name: Delete env files
if: github.event_name != 'pull_request'
run: rm -r .asv/env

- name: Push results to results repository
if: github.event_name != 'pull_request'
continue-on-error: true
Expand Down Expand Up @@ -113,21 +117,21 @@ jobs:
path: asv-compare-changed-output.log

- name: Find Comment
if: github.event_name == 'pull_request'
if: always() && github.event_name == 'pull_request'
uses: peter-evans/find-comment@v1
id: fc
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'tardis-bot'
issue-number: ${{ github.event.number }}
body-includes: I ran benchmarks as you asked

- name: Post comment
if: github.event_name == 'pull_request'
uses: peter-evans/create-or-update-comment@v2
with:
token: ${{ secrets.BOT_TOKEN }}
issue-number: ${{ github.event.pull_request.number }}
issue-number: ${{ github.event.number }}
comment-id: ${{ steps.fc.outputs.comment-id }}
edit-mode: replace
body: |
*\*beep\* \*bop\**
Hi human,
Expand All @@ -153,9 +157,6 @@ jobs:
</details>
env:
URL: https://github.com/${{ github.repository_owner }}/${{ github.event.repository.name }}/actions/runs/${{ github.run_id }}?check_suite_focus=true

- name: Delete env files
run: rm -r .asv/env

- name: Save results artifact
uses: actions/upload-artifact@v3
Expand Down