Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grotrian Diagram Plot Appearance #2313

Merged
merged 59 commits into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from 58 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
18c4da0
Grotrian diagram mockup 0
AyushiDaksh May 29, 2023
d721f2a
Use atomic data to get energy levels
AyushiDaksh Jun 1, 2023
6af58df
Get line data from simulation object using LastLineInteraction class
AyushiDaksh Jun 7, 2023
c5173a0
Remove transition where start and end (merged) levels is the same
AyushiDaksh Jun 8, 2023
cd5187d
Refactor to GrotrianWidget class
AyushiDaksh Jun 8, 2023
870e19b
Add hovertext and colorbar
AyushiDaksh Jun 8, 2023
0ea2da1
Fix NUM_SHELLS variable
AyushiDaksh Jun 9, 2023
de25ad9
Convert code into modular format
AyushiDaksh Jun 12, 2023
8309dda
Normalize wavelength by min and max value of the selected ion, instea…
AyushiDaksh Jun 15, 2023
cd51fd9
Create APIs for setting plot wavelength range manually
AyushiDaksh Jun 15, 2023
9473152
Make y-axis linear in level_number instead of level_energy
AyushiDaksh Jun 15, 2023
4271384
Rename num_electrons to standard_log_num_electrons while building plot
AyushiDaksh Jun 15, 2023
5f37765
Stardardize level population numbers
AyushiDaksh Jun 15, 2023
630e3aa
Fix stardardization division by zero if only one element present in data
AyushiDaksh Jun 15, 2023
ee41e3f
Fix roman notation of ion number
AyushiDaksh Jun 15, 2023
d8c6070
Display ground level too
AyushiDaksh Jun 15, 2023
c774e21
Change level populations to scientific notation in hovertext
AyushiDaksh Jun 15, 2023
9d06af9
Put Angstrom symbol in colorbar instead of full name
AyushiDaksh Jun 15, 2023
dcce132
Standardize num_electrons using a common range for both excitation an…
AyushiDaksh Jun 15, 2023
0f7e9ca
Fix the problem of arrows not touching the levels. (Used add_traces f…
AyushiDaksh Jun 15, 2023
b446a37
Refactor duplicated code logic
AyushiDaksh Jun 15, 2023
fec6fa7
Put hoverinfo on transition arrows
AyushiDaksh Jun 15, 2023
fcfa8e5
Put standardization logic into compute functions instead of draw func…
AyushiDaksh Jun 16, 2023
e0a49b0
Add width scale for level populations
AyushiDaksh Jun 16, 2023
60c3329
Format electron count to be an int instead of float in hovertext
AyushiDaksh Jun 16, 2023
2300f25
Wavelength range in colorbar should be confined to the displayed tran…
AyushiDaksh Jun 16, 2023
52c70fe
Set default colorscale to Rainbow for wavelengths
AyushiDaksh Jun 16, 2023
2dd3e5c
Allow user to set atomic number and ion number simultaneously
AyushiDaksh Jun 16, 2023
0a2878a
Handle ground state transitions correctly. Display dashed lines for l…
AyushiDaksh Jun 16, 2023
f44e65c
Add basic docstrings
AyushiDaksh Jun 21, 2023
f25a155
Scientific formatting for level energies
AyushiDaksh Jun 23, 2023
c34e773
Display level populations based on supernova zone
AyushiDaksh Jun 23, 2023
d6520c5
Put relative x-coordinate
AyushiDaksh Jun 25, 2023
51ce5fb
Add width scale for transition arrow widths
AyushiDaksh Jun 25, 2023
083e10b
Change y-axis from level number to log energies
AyushiDaksh Jun 25, 2023
80ae549
Minor margin changes
AyushiDaksh Jun 25, 2023
185c958
Disable zooming
AyushiDaksh Jun 26, 2023
b7ab916
Move width references to the left and colorbar to the right
AyushiDaksh Jun 28, 2023
3ef75fc
Refactor code. Remove duplication and hardcodings
AyushiDaksh Jun 29, 2023
9f70000
Add in/out last line interaction shell ids for real and virtual packets
AyushiDaksh Jun 29, 2023
c78089a
Add API for filtering data by supernova shell
AyushiDaksh Jun 29, 2023
3dc7389
Add selected shell in plot title
AyushiDaksh Jun 29, 2023
6016ca8
Do not handle last_line_interaction_in_shell_id and last_line_interac…
AyushiDaksh Jun 29, 2023
1739bb0
Do not reset custom wavelength range when the shell is changed
AyushiDaksh Jun 30, 2023
ca54c49
Sync mockup notebook with master
AyushiDaksh Jun 30, 2023
6a78dc9
Fixed plot width and reference bars
AyushiDaksh Jul 5, 2023
48eefdf
Added docstrings for remaining methods
AyushiDaksh Jul 6, 2023
9123504
Added log option for y-scale
AyushiDaksh Jul 7, 2023
10d933c
Resolve Black issue
AyushiDaksh Jul 7, 2023
4edeecc
Fix docstrings and make variable names more informative
AyushiDaksh Jul 10, 2023
68516d0
- Renamed 'colorscale' to 'cmapname'
AyushiDaksh Jul 10, 2023
e0845b4
Force user to set ion explicitly before plotting
AyushiDaksh Jul 10, 2023
3d629a9
Add information for the configurable attributes in the class docstring
AyushiDaksh Jul 11, 2023
cbba583
Remove hardcoding in the unit conversion for level energies
AyushiDaksh Jul 11, 2023
5656052
Fix arrowhead issue in VSCode
AyushiDaksh Jul 12, 2023
8265201
Display info message that wavelengths will be reset when ion changes
AyushiDaksh Jul 12, 2023
03759b3
Add ability to change level_diff_threshold, max_levels, and filter_mode
AyushiDaksh Jul 12, 2023
c419634
Added default parameter values in docstrings and updated comments
AyushiDaksh Jul 14, 2023
c9921d9
Make all setters atomic operations
AyushiDaksh Jul 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tardis/analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ def ion_number(self, value):
self._ion_number = value
self.update_last_interaction_filter()

def set_ion(self, atomic_number, ion_number):
self._atomic_number = atomic_number
self._ion_number = ion_number
self.update_last_interaction_filter()

@property
def shell(self):
return self._shell
Expand Down
Loading