Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hdf5 to v1.12 #2298

Merged
merged 2 commits into from
May 24, 2023
Merged

Bump hdf5 to v1.12 #2298

merged 2 commits into from
May 24, 2023

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 22, 2023

📝 Description

Type: 🪲 bugfix | 🎢 infrastructure

Trying to fix the annoying bug in the documentation pipeline. The hdf5 v1.10 package from conda-forge hasn't been updated in more than two years, so I'm proposing update it to v1.12 (latest is 1.14).

📌 Resources

See: https://anaconda.org/conda-forge/hdf5/files

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@epassaro epassaro reopened this May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #2298 (332bf0b) into master (0d18147) will not change coverage.
The diff coverage is n/a.

❗ Current head 332bf0b differs from pull request most recent head 6fcf85c. Consider uploading reports for the commit 6fcf85c to get more accurate results

@@           Coverage Diff           @@
##           master    #2298   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files         137      137           
  Lines       12514    12514           
=======================================
  Hits         9006     9006           
  Misses       3508     3508           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard
Copy link
Contributor

Why not the latest hdf5? Does that involve changing other dependencies?

@epassaro
Copy link
Member Author

Why not the latest hdf5? Does that involve changing other dependencies?

I was being conservative, v1.14 was launched a few months ago. I'm open to changing it if everyone agrees.

@atharva-2001 atharva-2001 merged commit a9bde5c into tardis-sn:master May 24, 2023
light2802 pushed a commit to light2802/tardis that referenced this pull request May 27, 2023
* Upgrade hdf5 to v1.12

* Add lockfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants