Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for update reference data workflow #2273

Merged
merged 3 commits into from
Apr 9, 2023
Merged

Fixes for update reference data workflow #2273

merged 3 commits into from
Apr 9, 2023

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Apr 4, 2023 •
edited
Loading

📝 Description

Type: 🚦 testing | 🎢 infrastructure

See the build log

  • Slash command works fine ✔️
  • Reference data is generated ✔️
  • Remove .lfs-assets-id ❌ reason: wrong directory
  • Post comment (failure) ❌ reason: wrong variable name

A patch has been commited.

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@epassaro
Copy link
Member Author

epassaro commented Apr 4, 2023

/update-refdata

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #2273 (346316d) into master (6cf502f) will not change coverage.
The diff coverage is n/a.

❗ Current head 346316d differs from pull request most recent head 8a2c98e. Consider uploading reports for the commit 8a2c98e to get more accurate results

@@           Coverage Diff           @@
##           master    #2273   +/-   ##
=======================================
  Coverage   71.88%   71.88%           
=======================================
  Files         133      133           
  Lines       12386    12386           
=======================================
  Hits         8904     8904           
  Misses       3482     3482

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epassaro epassaro self-assigned this Apr 4, 2023
@epassaro epassaro changed the title Test update reference data workflow Fixes for update reference data workflow Apr 4, 2023
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@epassaro epassaro marked this pull request as ready for review April 4, 2023 16:17
@andrewfullard andrewfullard enabled auto-merge (squash) April 4, 2023 22:25
@andrewfullard andrewfullard merged commit 390c174 into tardis-sn:master Apr 9, 2023
light2802 pushed a commit to light2802/tardis that referenced this pull request May 27, 2023
@epassaro @light2802
Fixes for update reference data workflow (tardis-sn#2273)
7c57877 
* Test update reference data workflow

* Add working directory to remove files step

* Fix post comment (failure) step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atharva-2001 atharva-2001 atharva-2001 approved these changes

@andrewfullard andrewfullard andrewfullard approved these changes

Assignees

@epassaro epassaro

Labels
build-docs CI/CD
Projects
CI/CD
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epassaro @tardis-bot @andrewfullard @atharva-2001