Check MD5 sums of downloaded atom data #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epassaro
commented
Mar 31, 2023
| @@ -396,9 +397,24 @@ def download_from_url(url, dst, src=None): | |||
| URL to download from | |||
| dst : str | |||
| Destination folder for the downloaded file | |||
| src : list | |||
| src : tuple | |||
There was a problem hiding this comment.
All the parameters must be hashable to memoize with lru_cache
andrewfullard
previously approved these changes
Apr 1, 2023
|
*beep* *bop* Hi, human. The Click here to see your results. |
…oader functions to check-checksums; Add retrying capabilities; Logging
epassaro
force-pushed
the
ci/check-hdf5-sum
branch
from
d7d8289 to
cf43c21
Compare
|
Rebased |
Codecov Report
@@ Coverage Diff @@
## master #2267 +/- ##
==========================================
- Coverage 71.88% 71.83% -0.05%
==========================================
Files 133 133
Lines 12384 12396 +12
==========================================
+ Hits 8902 8905 +3
- Misses 3482 3491 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andrewfullard
approved these changes
Apr 4, 2023
atharva-2001
approved these changes
Apr 10, 2023
light2802
pushed a commit
to light2802/tardis
that referenced
this pull request
May 27, 2023
* Add MD5 as a value on atom data YAML configuration file; Modify downloader functions to check-checksums; Add retrying capabilities; Logging * Sort modules * Reformatted with black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🎢infrastructureThis is an attempt to fix the random failure of the documentation pipeline. I always had the suspicion that HDF5 files sometimes are corrupted, but I can't be sure (
libhdf5is an awful library).In this PR I made the changes necessary to compare the known MD5 checksums of atomic files with the downloaded ones through the
download_atom_datafunction. Also, allows to set a maximum number of retries.Fixes #2252
📌 Resources
🚦 Testing
How did you test these changes?
Locally, modify a digit in the
md5key of thetardis/data/atomic_data_repo.ymlfile and call the function, see how in behaves until reaches the limit.☑️ Checklist
build_docslabel