Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating experimental model state #2118

Merged

Conversation

satwik-kambham
Copy link
Contributor

📝 Description

Type: : 🚀 restructure

Replacing old model state with restructured model state from #2114 .

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

tardis/model/base.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2118 (42af80c) into master (79f2fc3) will increase coverage by 0.09%.
The diff coverage is 92.30%.

❗ Current head 42af80c differs from pull request most recent head 4df6b25. Consider uploading reports for the commit 4df6b25 to get more accurate results

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   61.54%   61.63%   +0.09%     
==========================================
  Files          75       75              
  Lines        8635     8687      +52     
==========================================
+ Hits         5314     5354      +40     
- Misses       3321     3333      +12     
Impacted Files Coverage Δ
tardis/simulation/base.py 83.85% <50.00%> (ø)
tardis/model/base.py 88.77% <93.65%> (-1.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tardis/model/base.py Outdated Show resolved Hide resolved
tardis/model/tests/test_base.py Show resolved Hide resolved
tardis/model/base.py Show resolved Hide resolved
tardis/model/base.py Show resolved Hide resolved
@andrewfullard andrewfullard enabled auto-merge (squash) September 2, 2022 13:47
@wkerzendorf wkerzendorf merged commit f7f1f76 into tardis-sn:master Sep 12, 2022
@satwik-kambham satwik-kambham mentioned this pull request Sep 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants