Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Estimators and Convergence Docs #2108

Merged
merged 10 commits into from
Aug 3, 2022

Conversation

isaacgsmith
Copy link
Member

@isaacgsmith isaacgsmith commented Jul 29, 2022

📝 Description

Type: 📝 documentation

Revises the documentation's treatment of estimators and convergence. Creates an RST page in the montecarlo section about just the estimators, and creates a notebook in its own section about updating the plasma and convergence.

📌 Resources

Main changes:

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)
    Docs built on GitHub.

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2108 (8c2660c) into master (fb53e68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2108   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files          75       75           
  Lines        8617     8617           
=======================================
  Hits         5296     5296           
  Misses       3321     3321           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@isaacgsmith isaacgsmith marked this pull request as ready for review August 1, 2022 18:59
wkerzendorf
wkerzendorf previously approved these changes Aug 3, 2022
@wkerzendorf wkerzendorf enabled auto-merge (squash) August 3, 2022 15:51
auto-merge was automatically disabled August 3, 2022 18:56

Head branch was pushed to by a user without write access

@isaacgsmith isaacgsmith force-pushed the reorg_estimators_docs branch from 65ea85b to 85adcbd Compare August 3, 2022 18:56
@wkerzendorf wkerzendorf merged commit 973f9a5 into tardis-sn:master Aug 3, 2022
@isaacgsmith isaacgsmith deleted the reorg_estimators_docs branch August 4, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants