Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added positronium notes #2107

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jul 27, 2022

📝 Description

Type: 📝 documentation

Added some documentation for positronium discussion. Probably won't stay under the "energy input" header, but it's the best place to keep a record.

📌 Resources

See https://en.wikipedia.org/wiki/Positronium
Positronium spectrum https://ui.adsabs.harvard.edu/abs/1949PhRv...75.1696O
SN Ia commentary (section 2.2.2) https://ui.adsabs.harvard.edu/abs/2004ApJ...613.1101M/abstract

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2107 (033cadb) into master (6269996) will increase coverage by 3.19%.
The diff coverage is n/a.

❗ Current head 033cadb differs from pull request most recent head c90803f. Consider uploading reports for the commit c90803f to get more accurate results

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
+ Coverage   58.13%   61.33%   +3.19%     
==========================================
  Files          75       75              
  Lines        8602     8602              
==========================================
+ Hits         5001     5276     +275     
+ Misses       3601     3326     -275     
Impacted Files Coverage Δ
tardis/visualization/widgets/custom_abundance.py 59.53% <0.00%> (+42.96%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

tardis-bot commented Jul 27, 2022

*beep* *bop*

Hi, human.

The docs workflow has failed

Click here to see the build log.

Copy link
Member

@isaacgsmith isaacgsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold off on this until #2105 is merged? That will give us a good location for both the gammaray deposition and the positronium docs.

docs/physics/energy_input/positronium.rst Outdated Show resolved Hide resolved
@wkerzendorf wkerzendorf enabled auto-merge (squash) August 3, 2022 15:47
@wkerzendorf wkerzendorf disabled auto-merge August 3, 2022 15:47
@wkerzendorf wkerzendorf merged commit e924636 into tardis-sn:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants