-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Composition Class #2098
Merged
Rodot-
merged 25 commits into
tardis-sn:master
from
satwik-kambham:restructure-model-state
Aug 9, 2022
Merged
New Composition Class #2098
Rodot-
merged 25 commits into
tardis-sn:master
from
satwik-kambham:restructure-model-state
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
+ Coverage 61.33% 61.50% +0.16%
==========================================
Files 75 75
Lines 8602 8626 +24
==========================================
+ Hits 5276 5305 +29
+ Misses 3326 3321 -5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Just do the composition in this one. One PR one idea. |
satwik-kambham
changed the title
Model State Restructure based on new design
New Composition Class
Jul 22, 2022
wkerzendorf
reviewed
Jul 22, 2022
wkerzendorf
reviewed
Jul 22, 2022
Rodot-
requested changes
Jul 25, 2022
andrewfullard
previously approved these changes
Aug 1, 2022
wkerzendorf
reviewed
Aug 1, 2022
wkerzendorf
reviewed
Aug 3, 2022
wkerzendorf
reviewed
Aug 5, 2022
andrewfullard
previously approved these changes
Aug 5, 2022
Rodot-
reviewed
Aug 8, 2022
AlexHls
suggested changes
Aug 8, 2022
AlexHls
approved these changes
Aug 8, 2022
Rodot-
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🚀
restructure
New model state with composition and geometry classes.
📌 Resources