Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Composition Class #2098

Merged
merged 25 commits into from
Aug 9, 2022
Merged

Conversation

satwik-kambham
Copy link
Contributor

📝 Description

Type: 🚀 restructure

New model state with composition and geometry classes.

📌 Resources

New Model State Design

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #2098 (e1d9be4) into master (b0b04ee) will increase coverage by 0.16%.
The diff coverage is 80.00%.

❗ Current head e1d9be4 differs from pull request most recent head 41e5eca. Consider uploading reports for the commit 41e5eca to get more accurate results

@@            Coverage Diff             @@
##           master    #2098      +/-   ##
==========================================
+ Coverage   61.33%   61.50%   +0.16%     
==========================================
  Files          75       75              
  Lines        8602     8626      +24     
==========================================
+ Hits         5276     5305      +29     
+ Misses       3326     3321       -5     
Impacted Files Coverage Δ
tardis/io/config_validator.py 90.47% <ø> (ø)
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <ø> (ø)
tardis/montecarlo/montecarlo_numba/interaction.py 28.36% <ø> (+0.36%) ⬆️
...dis/montecarlo/montecarlo_numba/numba_interface.py 33.84% <0.00%> (-0.80%) ⬇️
tardis/io/util.py 77.98% <50.00%> (ø)
tardis/model/base.py 90.29% <100.00%> (+0.26%) ⬆️
tardis/montecarlo/montecarlo_numba/r_packet.py 61.53% <100.00%> (+11.53%) ⬆️
tardis/simulation/base.py 83.85% <100.00%> (+0.22%) ⬆️
tardis/montecarlo/montecarlo_numba/base.py 31.35% <0.00%> (+0.84%) ⬆️
tardis/io/logger/logger.py 75.86% <0.00%> (+5.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@satwik-kambham satwik-kambham self-assigned this Jul 20, 2022
@wkerzendorf
Copy link
Member

Just do the composition in this one. One PR one idea.

@satwik-kambham satwik-kambham changed the title Model State Restructure based on new design New Composition Class Jul 22, 2022
tardis/model/base.py Outdated Show resolved Hide resolved
tardis/model/base.py Outdated Show resolved Hide resolved
@satwik-kambham satwik-kambham marked this pull request as ready for review July 25, 2022 14:24
tardis/model/tests/test_base.py Outdated Show resolved Hide resolved
tardis/model/base.py Show resolved Hide resolved
tardis/model/base.py Outdated Show resolved Hide resolved
tardis/model/tests/test_base.py Outdated Show resolved Hide resolved
tardis/model/tests/test_base.py Outdated Show resolved Hide resolved
tardis/model/base.py Show resolved Hide resolved
andrewfullard
andrewfullard previously approved these changes Aug 1, 2022
tardis/model/base.py Outdated Show resolved Hide resolved
tardis/model/base.py Outdated Show resolved Hide resolved
tardis/model/base.py Outdated Show resolved Hide resolved
andrewfullard
andrewfullard previously approved these changes Aug 5, 2022
@Rodot- Rodot- requested a review from AlexHls August 8, 2022 14:25
tardis/model/base.py Outdated Show resolved Hide resolved
@satwik-kambham satwik-kambham requested a review from Rodot- August 8, 2022 14:41
@Rodot- Rodot- merged commit 7fdaf34 into tardis-sn:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants