Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fix for He NLTE. #2096

Merged
merged 5 commits into from Sep 28, 2022
Merged

Small bug fix for He NLTE. #2096

merged 5 commits into from Sep 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2022

📝 Description

Type: 🪲 bugfix

With the new format for the atomic data associated with Boyle et al. (2016), an issue arises when calling the degeneracy factor g using the indexing g.loc[2,1,0], for example. I have replaced this with just the number that would be read in each case. These numbers would never need to change.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe): Tested manually.
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #2096 (eb8a42c) into master (a2ed8b5) will increase coverage by 3.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
+ Coverage   58.13%   61.63%   +3.49%     
==========================================
  Files          75       75              
  Lines        8602     8687      +85     
==========================================
+ Hits         5001     5354     +353     
+ Misses       3601     3333     -268     
Impacted Files Coverage Δ
tardis/plasma/properties/nlte.py 40.56% <ø> (ø)
tardis/model/base.py 88.77% <0.00%> (-1.26%) ⬇️
...dis/montecarlo/montecarlo_numba/numba_interface.py 33.84% <0.00%> (-0.80%) ⬇️
tardis/plasma/base.py 48.64% <0.00%> (-0.27%) ⬇️
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <0.00%> (ø)
tardis/simulation/base.py 83.85% <0.00%> (+0.22%) ⬆️
tardis/energy_input/energy_source.py 28.00% <0.00%> (+0.36%) ⬆️
tardis/montecarlo/montecarlo_numba/interaction.py 28.36% <0.00%> (+0.36%) ⬆️
tardis/montecarlo/montecarlo_numba/base.py 31.35% <0.00%> (+0.84%) ⬆️
tardis/io/logger/logger.py 75.86% <0.00%> (+5.17%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis/plasma/properties/nlte.py Outdated Show resolved Hide resolved
tardis/plasma/properties/nlte.py Outdated Show resolved Hide resolved
@andrewfullard andrewfullard enabled auto-merge (squash) September 19, 2022 14:33
@andrewfullard andrewfullard self-requested a review September 19, 2022 14:33
@wkerzendorf wkerzendorf merged commit 9ecc794 into tardis-sn:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants