Arepo docs fix #2088

AlexHls · 2022-07-12T14:39:03Z

📝 Description

Type: 🪲 bugfix

Fix to failing docs build.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

review-notebook-app · 2022-07-12T14:39:08Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tardis-bot · 2022-07-12T14:39:56Z

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

tardis-bot · 2022-07-12T14:43:28Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot · 2022-07-12T14:49:05Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

codecov · 2022-07-12T15:00:39Z

Codecov Report

Merging #2088 (9c52b7e) into master (e01e44a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2088   +/-   ##
=======================================
  Coverage   58.13%   58.13%           
=======================================
  Files          75       75           
  Lines        8602     8602           
=======================================
  Hits         5001     5001           
  Misses       3601     3601

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

tardis-bot · 2022-07-12T15:16:19Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot · 2022-07-13T13:21:40Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

epassaro · 2022-07-13T14:48:23Z

Read the instructions at the pull request body @AlexHls

tardis-bot · 2022-07-13T14:50:21Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

epassaro · 2022-07-13T14:57:59Z

You are commiting with the [email protected] email @AlexHls , please add that to .mailmap

epassaro · 2022-07-13T15:55:16Z

The label required to build the docs is this, it's not necessary to write anything in the commit name (we deprecated that 2-3 months ago).

epassaro · 2022-07-13T15:56:45Z

.mailmap

@@ -1,6 +1,7 @@
 Adam Suban-Loewen <[email protected]>

 Alexander Holas <[email protected]>
+Alexander Holas <[email protected]>


I think should be:

Alexander Holas <[email protected]> Alexander Holas <[email protected]>

* [build-docs] Fixed link in arepo docs * [build-docs] Changed filename in arepo docs * [build-docs] * [build-docs] * [build-docs] * [build docs] * [build-docs] Changed refdata url * [build_docs] * Updated mailmap * [build_docs] Updated url for refdata download

* rpacket_tracker returns dataframe * added black formatting * replaced variable i * added rpacket_tracker_df as separate variable * added preallocation step * added non-preallocated-df generator function * tests for df generator function * renamed variables * assert statements corrected * added seed column in df * added documentation for rpacket_tracker_df * added doc str * initial commit * updated documention * moved function to r_packet.py * added block indexing to df Co-authored-by: Wolfgang Kerzendorf <[email protected]> * updated the df function * added multiindexing * shifted the df function call * initial commit * interaction type added * removed unused imports * added tests * initial commit * interaction type added * Created a smart HDF Reader which can re-produce simulation object (#2052) * Added functions to store and load a runner object * Updated hardcode file name in runner_from_hdf * Updated store_runner_to_hdf to append to file * Added name and email to .mailmap * runner hdf functions convert to cgs * store_runner_to_hdf clears group before storing * Storing units for astropy quantities * Formatted code with black * Added functions to store and load model objects * Fixed typo and decoded string from bytes * Fixed typo * Added test for model_to_dict * Formatted previous test code * Added test for store_model_to_hdf * Fixed formatting of model_to_hdf * Fixed issue with test for model_to_dict * Added test for runner_to_dict * Fixed issue with single packet seed storage * Updated test null value of single packet seed * Added test for store_runner_to_hdf * Updated to use isinstance and hasattr * runner_to_dict returns dicts instead of iterators * Reordered imports to match pep8 style * Remove yaml_load_config_file (#2062) * Remove yaml_load_config_file * updated mailmap * Updated __init__.py * Modified Function Name in Config validator according to PEP8 (#2076) Fix function name according pep8 * Added documetation on how to compare environment before update (#2082) * Moved `trace_packet` to tardis tansport (#2083) * Moved the trace_packet function to the transport module, renamed the function to remove continuum reference as it is generic * Formatted to PEP 8 * Reformatted single_packet_loop for PEP 8 * removed old continuum trace packet files * removed references to old files * Added some docstrings * Missed an old function call * Fix broken links in workflow files and goverance md (#2084) * Adding physics introduction to documentation (#2026) * creating files and sections * adding images * writing intro to tardis physics and adding it to sidebar * changing spectra page structure * mostly complete draft of light and matter page * spectrum page * fixing up physics stuff * fixing docstring * Revert "fixing docstring" This reverts commit e24cadd. * andrew's changes * a few more edits * adding note about angstroms * Improved arepo parser (#1941) * Removed line profile as option * Removed mapping to Cartesian grid * Removed automatic plotting after profile creation * Fixed typo in arepo plot * Updated documentation * [build docs] * [build docs] Removed outputs from doc-notebook * Updated tests with new models * Removed deprecated keyword in snapshot loader * Replaced wget with requests for testfile download * Updated file retrieval for testing * Fixed fixture request * Added arepo data to refdata helper * Updated refdata location in docs * Updated paths in tests * Update download_reference_data.sh * Testing areop_parser_tests * Fixed deleted reference file * Arepo docs fix (#2088) * [build-docs] Fixed link in arepo docs * [build-docs] Changed filename in arepo docs * [build-docs] * [build-docs] * [build-docs] * [build docs] * [build-docs] Changed refdata url * [build_docs] * Updated mailmap * [build_docs] Updated url for refdata download * Creating new docs building instructions (#2097) * creating new docs building instructions * typos, grammar, and text in hyperlinks * added tests * added documentation, black formatting Co-authored-by: Wolfgang Kerzendorf <[email protected]> Co-authored-by: Satwik Kambham <[email protected]> Co-authored-by: aman kumar <[email protected]> Co-authored-by: Rohith Varma Buddaraju <[email protected]> Co-authored-by: Jaladh Singhal <[email protected]> Co-authored-by: Jack O'Brien <[email protected]> Co-authored-by: Isaac Smith <[email protected]> Co-authored-by: AlexHls <[email protected]>

AlexHls added 3 commits July 12, 2022 09:47

[build-docs] Fixed link in arepo docs

7f31e0e

[build-docs] Changed filename in arepo docs

831b362

[build-docs]

7abc33c

[build-docs]

652150f

AlexHls marked this pull request as ready for review July 12, 2022 14:48

[build-docs]

14af011

wkerzendorf self-requested a review July 12, 2022 14:48

wkerzendorf approved these changes Jul 12, 2022

View reviewed changes

AlexHls requested a review from Rodot- July 12, 2022 15:14

[build docs]

ad332a0

AlexHls requested a review from andrewfullard July 12, 2022 18:58

AlexHls mentioned this pull request Jul 13, 2022

Documentation on buiding docs is outdated #2089

Closed

2 tasks

[build-docs] Changed refdata url

9a52014

[build_docs]

9da9b56

epassaro added the build-docs label Jul 13, 2022

AlexHls added 2 commits July 13, 2022 11:20

Updated mailmap

35d1d51

[build_docs] Updated url for refdata download

9c52b7e

epassaro reviewed Jul 13, 2022

View reviewed changes

epassaro self-requested a review July 13, 2022 16:16

epassaro approved these changes Jul 13, 2022

View reviewed changes

Rodot- approved these changes Jul 14, 2022

View reviewed changes

Rodot- merged commit a2ed8b5 into tardis-sn:master Jul 14, 2022

AlexHls deleted the arepo-docs-fix branch July 14, 2022 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arepo docs fix #2088

Arepo docs fix #2088

AlexHls commented Jul 12, 2022

review-notebook-app bot commented Jul 12, 2022

tardis-bot commented Jul 12, 2022 •

edited

Loading

tardis-bot commented Jul 12, 2022

tardis-bot commented Jul 12, 2022

codecov bot commented Jul 12, 2022 •

edited

Loading

tardis-bot commented Jul 12, 2022

tardis-bot commented Jul 13, 2022

epassaro commented Jul 13, 2022

tardis-bot commented Jul 13, 2022

epassaro commented Jul 13, 2022

epassaro commented Jul 13, 2022 •

edited

Loading

epassaro Jul 13, 2022

Arepo docs fix #2088

Arepo docs fix #2088

Conversation

AlexHls commented Jul 12, 2022

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

review-notebook-app bot commented Jul 12, 2022

tardis-bot commented Jul 12, 2022 • edited Loading

tardis-bot commented Jul 12, 2022

tardis-bot commented Jul 12, 2022

codecov bot commented Jul 12, 2022 • edited Loading

Codecov Report

tardis-bot commented Jul 12, 2022

tardis-bot commented Jul 13, 2022

epassaro commented Jul 13, 2022

tardis-bot commented Jul 13, 2022

epassaro commented Jul 13, 2022

epassaro commented Jul 13, 2022 • edited Loading

epassaro Jul 13, 2022

Choose a reason for hiding this comment

tardis-bot commented Jul 12, 2022 •

edited

Loading

codecov bot commented Jul 12, 2022 •

edited

Loading

epassaro commented Jul 13, 2022 •

edited

Loading