Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial geometry restructure #2063

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

nolanbrown01
Copy link
Contributor

@nolanbrown01 nolanbrown01 commented Jun 20, 2022

📝 Description

Moved calculate_distances to a new folder, transport. Renamed dependencies.

Type: 🎢 infrastructure

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #2063 (967aef9) into master (d20659e) will increase coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head 967aef9 differs from pull request most recent head c712c24. Consider uploading reports for the commit c712c24 to get more accurate results

@@           Coverage Diff           @@
##           master    #2063   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          76       76           
  Lines        8599     8593    -6     
=======================================
- Hits         5017     5014    -3     
+ Misses       3582     3579    -3     
Impacted Files Coverage Δ
tardis/montecarlo/base.py 87.60% <ø> (-0.06%) ⬇️
tardis/montecarlo/montecarlo_configuration.py 100.00% <ø> (ø)
tardis/montecarlo/montecarlo_numba/base.py 30.50% <0.00%> (+0.75%) ⬆️
...dis/montecarlo/montecarlo_numba/numba_interface.py 34.64% <ø> (-0.26%) ⬇️
tardis/transport/calculate_distances.py 34.88% <ø> (ø)
...lo_numba/continuum/r_packet_transport_continuum.py 15.15% <100.00%> (ø)
.../montecarlo/montecarlo_numba/r_packet_transport.py 20.00% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/vpacket.py 21.78% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nolanbrown01 nolanbrown01 marked this pull request as ready for review June 20, 2022 16:05
@andrewfullard andrewfullard merged commit 20cb998 into tardis-sn:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants