Minor but critical fix to binary search (reverse) #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssim does it work for you with this now? |
|
The file I got from @orbitfold works for me (without errors) with this fix, yes. |
|
@ssim great go ahead and merge - thanks for looking into this |
|
ok - will do |
ssim
added a commit
that referenced
this pull request
Dec 5, 2014
Minor but critical fix to binary search (reverse)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #204
Proposed fix to the issue raised in #204
I believe this is a typo (but, unfortunately, a mission critical one) in the reverse binary search.
Please check / comment and accept @wkerzendorf @mklauser @orbitfold
Note related issue I'm about to post about the "binary_search"