Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore gamma-ray deposition notebook for now #2047

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jun 7, 2022

📝 Description

Fixes the doc build failure due to incorrect file references- the gamma-ray notebook will be rewritten in future.

Type: 🪲 bugfix

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2047 (d8132dc) into master (63028ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2047   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          76       76           
  Lines        8599     8599           
=======================================
  Hits         5017     5017           
  Misses       3582     3582           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@@ -337,6 +338,7 @@

from shutil import copyfile


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from black

@epassaro epassaro merged commit c5ca2e3 into tardis-sn:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants