Check PEP8 on CI #2039
Merged
Check PEP8 on CI #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epassaro
force-pushed
the
ci/flake8-on-ci
branch
2 times, most recently
from
368a849 to
192a9ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #2039 +/- ##
==========================================
- Coverage 59.88% 59.87% -0.01%
==========================================
Files 70 70
Lines 8154 8157 +3
==========================================
+ Hits 4883 4884 +1
- Misses 3271 3273 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
andrewfullard
approved these changes
May 31, 2022
|
I agree that we need to run flake8 on TARDIS before merging this PR. |
Also requires fine-tuning:
|
epassaro
added a commit
to epassaro/tardis
that referenced
this pull request
Jun 2, 2022
* Add Flake8 job * Change to file description
epassaro
added a commit
to epassaro/tardis
that referenced
this pull request
Jun 2, 2022
* Fix bot aliases in .mailmap (tardis-sn#2038) * Added v_inner and v_outer, enable_nonhomologous_expansion for future use in nonhomologous expansion (tardis-sn#2024) * added v_outer and v_inner to NumbaModel * defined default value for v_inner and v_outer in NumbaModel * added enable_nonhomologous_expansion to io/schemas/montecarlo.yml * added v_inner and v_outer to NumbaPlasma * added v_inner and v_outer as arguments for NumbaModel in run() in montecarlo_numba * added v_outer_cgs to MonteCarloRunner * removed a comment * ran black on the changed files * added right arguments in test * added v_inner, v_outer to tests * added temporary fix to formal_integral.py * ran black on modified files * changed dummy values in the test * Reverted content of file. * made needed change in test_cuda_formal_integral.py * made needed change in test_numba_formal_integral.py * Update README.rst in post-release (tardis-sn#2037) * Fix docs badge * Add license badge * First attempt of creating credits.rst and README.rst via templates * Working version * Restore old README.rst * Update post-release workflow * Change .gitignore * Various fixes * Check PEP8 on CI (tardis-sn#2039) * Add Flake8 job * Change to file description * Test payload Co-authored-by: Sona Chitchyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🚀
feature| 🎢infrastructureCloses #1762
I propose merging this (the job works but it's skipped) until someone has time to make the TARDIS PEP8 complaint again.
📌 Resources
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel