-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dockerfile and docker workflow #2029
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 137 137
Lines 12514 12514
=======================================
Hits 9006 9006
Misses 3508 3508 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.github/workflows/docker.yml
Outdated
- name: Extract metadata | ||
uses: docker/metadata-action@v4 | ||
with: | ||
images: tardis-rt/tardis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed this new account is going to be named tardis-rt
.
I don't know very much about Docker, I'll try this out when I get the time |
Great, tell me if you have any doubt. Do you know someone in TARDIS that knows about Docker and should be a reviewer of this PR? |
I do not. You should ask on Slack. |
172d6c6
to
7576689
Compare
5d3cda8
to
f27301f
Compare
*beep* *bop* Hi, human. The Click here to see the build log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very great addition @epassaro 🎉
I tried running it locally - it works perfectly except I had to install curl otherwise quickstart notebook wasn't able to download tardis_example.yml. Perhaps, we can add following step in dockerfile:
RUN apt-get update && apt-get install -y \
curl
But I understand if we don't since quickstart notebook isn't the only thing container users are gonna use. As you know better, it's your call whether we should add this or not, hence I'm approving it!
Sounds good @epassaro! |
f27301f
to
af9d407
Compare
83f0d7a
to
af9d407
Compare
aaea3c1
to
dd3c96a
Compare
Closed in favor of PR #2569. |
Description
Dockerfile
with a fully functioning TARDIS.master
(latest changes, gets overwritten on every push to master),<tag-name>
(on release), andlatest
(points to latest tag, on release).Motivation and context
Run TARDIS everywhere.
How has this been tested?
Locally build and run the Docker image:
To re-start an exited container, first check the
NAMES
field of your container withdocker ps -a
and thenExamples
Type of change
Checklist
build_docs
label to this pull request (if you don't have enough privileges a reviewer will do it for you)