Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for CITATION.cff #2020

Merged
merged 3 commits into from
May 26, 2022
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 10, 2022

Description

  • Wait for the Zenodo webhook, otherwise CITATION.cff is not modified.
  • doi2cff update does not update the title field and author order, use doi2cff init instead

Motivation and context

How has this been tested?

  • Testing pipeline
  • Other

Examples

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • None of the above

Checklist

  • I have updated the documentation according to my changes
  • I have built the documentation by applying the build_docs label to this pull request (if you don't have enough privileges a reviewer will do it for you)
  • I have requested two reviewers for this pull request

@epassaro epassaro requested a review from andrewfullard May 10, 2022 13:07
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #2020 (76264d8) into master (120b303) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   60.01%   59.88%   -0.13%     
==========================================
  Files          70       70              
  Lines        8115     8154      +39     
==========================================
+ Hits         4870     4883      +13     
- Misses       3245     3271      +26     
Impacted Files Coverage Δ
tardis/io/atom_data/base.py 81.81% <0.00%> (-7.90%) ⬇️
tardis/io/atom_data/atom_web_download.py 40.00% <0.00%> (-2.11%) ⬇️
tardis/montecarlo/montecarlo_numba/base.py 29.75% <0.00%> (-2.07%) ⬇️
...dis/montecarlo/montecarlo_numba/numba_interface.py 35.17% <0.00%> (-1.04%) ⬇️
tardis/plasma/properties/continuum_processes.py 35.75% <0.00%> (ø)
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <0.00%> (ø)
tardis/plasma/properties/atomic.py 55.73% <0.00%> (+0.62%) ⬆️
tardis/io/util.py 78.26% <0.00%> (+6.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@@ -36,6 +36,9 @@ jobs:
steps:
- uses: actions/checkout@v2

- name: Wait for Zenodo webhook
run: sleep 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded sleep seems like an issue- is there a way to link the action as a wait instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. That's out of our control, depends on how much time requires Zenodo to make a new release on their server. 2 mins seems enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if this wait time is exceeded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pull request is opened just with changes in CHANGELOG.rst, CITATION.cff will not updated because the release was the same at that moment the job started.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this behavior in either the automated PR message or the development documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done, the warning looks like this: #2018

@epassaro epassaro requested a review from andrewfullard May 23, 2022 21:17
@epassaro epassaro merged commit 09a17b7 into tardis-sn:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants