-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CITATION.cff #2020
Fixes for CITATION.cff #2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
==========================================
- Coverage 60.01% 59.88% -0.13%
==========================================
Files 70 70
Lines 8115 8154 +39
==========================================
+ Hits 4870 4883 +13
- Misses 3245 3271 +26
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@@ -36,6 +36,9 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v2 | |||
|
|||
- name: Wait for Zenodo webhook | |||
run: sleep 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded sleep seems like an issue- is there a way to link the action as a wait instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. That's out of our control, depends on how much time requires Zenodo to make a new release on their server. 2 mins seems enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if this wait time is exceeded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pull request is opened just with changes in CHANGELOG.rst, CITATION.cff will not updated because the release was the same at that moment the job started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this behavior in either the automated PR message or the development documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done, the warning looks like this: #2018
Description
CITATION.cff
is not modified.doi2cff update
does not update thetitle
field and author order, usedoi2cff init
insteadMotivation and context
How has this been tested?
Examples
Type of change
Checklist
build_docs
label to this pull request (if you don't have enough privileges a reviewer will do it for you)