-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compatability to current version of carsus atomic data #2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
- Coverage 60.04% 60.01% -0.03%
==========================================
Files 70 70
Lines 8121 8133 +12
==========================================
+ Hits 4876 4881 +5
- Misses 3245 3252 +7
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Should be noted, this branch now seems to work but it must be run single-threaded. |
We should start thinking about writing tests, but that could go into a later PR, what does everyone think? |
We are currently adding more metadata and versioning Carsus format, so the key checkingássigning must be handled differently. I hope we have this ready for Thursday. EDIT: I mean, after these new changes the new Carsus files are going to be signed with "format_version: v1.0" and old atomic files must be identified as "legacy" or something like that in TARDIS. |
Carsus format support
run black on the changed file
Is this ready? @sonachitchyan @Rodot- |
*beep* *bop* Hi, human. The Click here to see your results. |
We can say this has been tested against old Carsus atomic files. New atomic files were tested locally, right? |
Yep, we tested the new ones locally and the old ones are tested by the pipeline |
… version. This commit also adds credit to all of the people who helped out building this PR who are not already marked as contributors Co-authored-by: Sona Chitchyan <[email protected]> Co-authored-by: Christian Vogl <[email protected]> Co-authored-by: Ezequiel Pássaro <[email protected]> Co-authored-by: Laureano Martinez <[email protected]>
@epassaro @andrewfullard @chvogl I think this is ready to merge if you add your approvals, unless anyone has any final comments. |
Changed the way that the atomic data objects are instantiated in TARDIS to handle atomic data produced by carsus
Motivation and context
Currently, carsus and tardis are incompatible when using atomic data containing collisional data.
How has this been tested?
Local tests with current carsus branch
Examples
Type of change
Checklist
build_docs
label to this pull request (if you don't have enough privileges a reviewer will do it for you)