Enable automerge on pre and post-release workflows #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epassaro
force-pushed
the
ci/enable-automerge
branch
from
db7d4bf to
ee89b5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
=======================================
Coverage 59.87% 59.87%
=======================================
Files 70 70
Lines 8157 8157
=======================================
Hits 4884 4884
Misses 3273 3273 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
epassaro
force-pushed
the
ci/enable-automerge
branch
from
6a5228f to
dce47c7
Compare
epassaro
force-pushed
the
ci/enable-automerge
branch
2 times, most recently
from
7290f18 to
267d441
Compare
epassaro
force-pushed
the
ci/enable-automerge
branch
from
3888117 to
cb9a242
Compare
|
*beep* *bop* Hi, human. The Click here to see the build log. |
epassaro
force-pushed
the
ci/enable-automerge
branch
from
7c233b9 to
cb9a242
Compare
epassaro
changed the title
epassaro
force-pushed
the
ci/enable-automerge
branch
3 times, most recently
from
4255814 to
8228180
Compare
epassaro
force-pushed
the
ci/enable-automerge
branch
3 times, most recently
from
82fd7fa to
c756f32
Compare
epassaro
force-pushed
the
ci/enable-automerge
branch
from
55e96c0 to
9062801
Compare
epassaro
force-pushed
the
ci/enable-automerge
branch
from
653deae to
b7a1a0c
Compare
epassaro
changed the title
epassaro
requested review from
andrewfullard and
wkerzendorf
and removed request for
tardis-bot
|
Seems sensible, assuming we set the bot up correctly. |
epassaro
force-pushed
the
ci/enable-automerge
branch
from
862c6ce to
4574a52
Compare
epassaro
force-pushed
the
ci/enable-automerge
branch
from
4574a52 to
dbf904b
Compare
Rodot-
approved these changes
Jun 6, 2022
andrewfullard
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automerge requires important changes in the TARDIS infrastructure:
Add branch protection rules to enforce passingDONEtestsanddocsbefore merging a pull requestMake @tardis-bot a less privileged user to avoid merging pull requests with failing tests. In this moment the bot has administator rights and does not follow the principle of least privilege. All the operations made by the bot can be performed with less privileges (see this table)DONEThis pull request makes minor changes to
preandpostrelease:Other changes:
docsworkflow (required to mark this job as a required status check before automerge).Motivation and context
How has this been tested?
Examples
Type of change
Checklist
build_docslabel to this pull request (if you don't have enough privileges a reviewer will do it for you)