Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removing Levels Index Variable Within Atomic Data Preperation" #2009

Merged
merged 1 commit into from
May 4, 2022

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented May 4, 2022

Reverts #1957

These quantities are necessary for the continuum interaction. In the future, be careful removing "unused" properties as they may be required for ongoing physics implementations. If these are slowing down the computation, you can use the CONTINUUM_PROCESS_ENABLED config variable to check if you want them computed

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2009 (6a76f98) into master (76f4413) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
+ Coverage   59.99%   60.01%   +0.01%     
==========================================
  Files          70       70              
  Lines        8112     8115       +3     
==========================================
+ Hits         4867     4870       +3     
  Misses       3245     3245              
Impacted Files Coverage Δ
tardis/io/atom_data/base.py 89.71% <100.00%> (+0.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wkerzendorf wkerzendorf merged commit 98ef5b9 into master May 4, 2022
@andrewfullard andrewfullard deleted the revert-1957-levels_filter branch July 20, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants