Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move link_t_rad_t_electron to config file #2008

Merged
merged 4 commits into from
May 5, 2022

Conversation

sonachitchyan
Copy link
Member

Moved link_t_rad_t_electron from being defined in standard_plasmas.py to plasma.yml in io/schemas
Description

Motivation and context

How has this been tested?

  • Testing pipeline
  • Other

Examples

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • None of the above

Checklist

  • I have updated the documentation according to my changes
  • I have built the documentation by applying the build_docs label to this pull request (if you don't have enough privileges a reviewer will do it for you)
  • I have requested two reviewers for this pull request

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2008 (12dde85) into master (1133636) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 12dde85 differs from pull request most recent head 192f28c. Consider uploading reports for the commit 192f28c to get more accurate results

@@            Coverage Diff             @@
##           master    #2008      +/-   ##
==========================================
+ Coverage   59.99%   60.01%   +0.01%     
==========================================
  Files          70       70              
  Lines        8112     8115       +3     
==========================================
+ Hits         4867     4870       +3     
  Misses       3245     3245              
Impacted Files Coverage Δ
tardis/plasma/standard_plasmas.py 74.48% <ø> (ø)
tardis/io/atom_data/base.py 89.71% <100.00%> (+0.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Co-authored-by: Wolfgang Kerzendorf <[email protected]>
Copy link
Contributor

@chvogl chvogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonachitchyan sonachitchyan merged commit 66eb19f into tardis-sn:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants