Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for isotope abundance parsing #2003

Merged
merged 2 commits into from
May 4, 2022

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented May 3, 2022

The CSVY parsing of isotope abundances does not provide them to the plasma pre-cut for the inner and outer velocity bounaries

Description
Now the proper isotope abundance array with velocity cuts is passed to the correct plasma properties.

Motivation and context

How has this been tested?

  • Testing pipeline
  • Other

Examples

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • None of the above

Checklist

  • I have updated the documentation according to my changes
  • I have built the documentation by applying the build_docs label to this pull request (if you don't have enough privileges a reviewer will do it for you)
  • I have requested two reviewers for this pull request

@Rodot- Rodot- marked this pull request as draft May 3, 2022 15:18
…ttributtes in the plasma but at least it runs
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2003 (4f14c22) into master (1761515) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4f14c22 differs from pull request most recent head 344e015. Consider uploading reports for the commit 344e015 to get more accurate results

@@           Coverage Diff           @@
##           master    #2003   +/-   ##
=======================================
  Coverage   59.99%   59.99%           
=======================================
  Files          70       70           
  Lines        8111     8112    +1     
=======================================
+ Hits         4866     4867    +1     
  Misses       3245     3245           
Impacted Files Coverage Δ
tardis/plasma/standard_plasmas.py 74.48% <100.00%> (+0.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Rodot- Rodot- marked this pull request as ready for review May 3, 2022 15:52
@Rodot- Rodot- requested a review from marxwillia May 3, 2022 15:58
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The build-docs workflow has succeeded ✔️

Click here to see your results.

@epassaro epassaro self-requested a review May 4, 2022 15:58
@Rodot- Rodot- merged commit c07ec8e into tardis-sn:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants