Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency groups in workflows #1998

Merged
merged 1 commit into from
May 2, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 2, 2022

Description

Trying to mimic the behavior of Azure Pipelines:

  • Pushing two times to master should cancel the first run and build only for the latest commit
  • Same for pushing to PRs
  • Pushes to a certain PR shouldn't cancel other PRs builds
  • Pushes to PRs shouldn't cancel master builds and vice-versa

See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro requested a review from andrewfullard May 2, 2022 20:50
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1998 (9e8136d) into master (37a9769) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e8136d differs from pull request most recent head c41ce69. Consider uploading reports for the commit c41ce69 to get more accurate results

@@           Coverage Diff           @@
##           master    #1998   +/-   ##
=======================================
  Coverage   59.99%   59.99%           
=======================================
  Files          70       70           
  Lines        8111     8111           
=======================================
  Hits         4866     4866           
  Misses       3245     3245           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro merged commit 713c9db into tardis-sn:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants