Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for compare-refdata pipeline #1996

Merged
merged 3 commits into from
May 6, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 2, 2022

Description

⚠️ This pipeline is going to be ported to GitHub actions very soon

These changes are only to make the pipeline work just in case someone needs it in the next few days.

  • I noticed this pipeline is capable to work with the mirrored reference data if you don't require to fetch pull requests from the tardis-refdata repository.
  • Needed to re-apply the "old" patch to fetch from Azure due to a still unresolved authentication bug.
  • Fixed paths in OpenSupernova server.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

The reference data pipeline itself.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft May 2, 2022 17:14
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1996 (2de1a3a) into master (66eb19f) will not change coverage.
The diff coverage is n/a.

❗ Current head 2de1a3a differs from pull request most recent head 441b4b1. Consider uploading reports for the commit 441b4b1 to get more accurate results

@@           Coverage Diff           @@
##           master    #1996   +/-   ##
=======================================
  Coverage   60.01%   60.01%           
=======================================
  Files          70       70           
  Lines        8115     8115           
=======================================
  Hits         4870     4870           
  Misses       3245     3245           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro force-pushed the ci/compare-refdata-paths branch from 53bc9d6 to 81c03f5 Compare May 2, 2022 21:55
@epassaro epassaro added the CI/CD label May 2, 2022
@epassaro epassaro force-pushed the ci/compare-refdata-paths branch from 81c03f5 to 8b5a444 Compare May 5, 2022 16:20
@epassaro
Copy link
Member Author

epassaro commented May 5, 2022

/azp run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build succeeded 2de1a3a

Click here to see results.

@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot May 5, 2022
@epassaro epassaro force-pushed the ci/compare-refdata-paths branch from a875b26 to 441b4b1 Compare May 5, 2022 17:19
@epassaro epassaro requested review from andrewfullard and Rodot- May 5, 2022 17:38
@epassaro epassaro marked this pull request as ready for review May 5, 2022 17:38
@epassaro epassaro merged commit 16ce307 into tardis-sn:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants