Force constant version date length #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epassaro
force-pushed
the
ci/fixed-ver-length
branch
from
d775e31 to
6c2f344
Compare
Codecov Report
@@ Coverage Diff @@
## master #1995 +/- ##
=======================================
Coverage 59.99% 59.99%
=======================================
Files 70 70
Lines 8111 8111
=======================================
Hits 4866 4866
Misses 3245 3245 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
I feel like there's a better way to do this with a datetime transformation to ISO format? https://docs.python.org/3/library/datetime.html#datetime.date.isoformat |
epassaro
changed the title
Ok, then I should use |
|
@andrewfullard done |
epassaro
commented
May 3, 2022
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| import sys | |||
| from setuptools_scm import version_from_scm | |||
| from setuptools_scm.version import guess_next_date_ver | |||
epassaro
commented
May 3, 2022
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| import sys | |||
| from setuptools_scm import version_from_scm | |||
| from setuptools_scm.version import guess_next_date_ver | |||
| iso_date = date(*release).isoformat() | ||
| iso_date = iso_date.replace("-",".") | ||
|
|
||
| version = f"{iso_date}.{str(build)}" | ||
| version = version.rstrip(".0") if version.endswith(".0") else version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, version names have the form
tardis-YYYY.MM.DD.Bwith:Y: year
M: month
D: day
B: build number (if build number is >0, otherwise version is just
YYYY.MM.DD)But for months from 1-9 and days from 1-9 the version is resolved as YYYY.M.D.
With this patch the number of digits is always 8.
Motivation and context
How has this been tested?
Locally run with the
tardisenv activated:python .ci-helpers/get_next_version.pyExamples
Type of change
Checklist