Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot comment with directions to update .mailmap #1982

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Apr 25, 2022

Description

This new step should write a comment giving some directions to new contributors on how to add themselves to .mailmap.

However, this new feature can't be tested without merging since the pull_request_target trigger lives in the base of the pull request for security purposes.

The sample message is reproduced in a comment below.

Should we also mention the TARDIS Code of Conduct? @wkerzendorf

Motivation and context

Closes #1972

How has this been tested?

  • Testing pipeline.
  • Other.
    Not possible to test.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft April 25, 2022 22:51
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1982 (82c1ec5) into master (01a018d) will not change coverage.
The diff coverage is n/a.

❗ Current head 82c1ec5 differs from pull request most recent head 68eaa57. Consider uploading reports for the commit 68eaa57 to get more accurate results

@@           Coverage Diff           @@
##           master    #1982   +/-   ##
=======================================
  Coverage   59.85%   59.85%           
=======================================
  Files          70       70           
  Lines        8080     8080           
=======================================
  Hits         4836     4836           
  Misses       3244     3244           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro
Copy link
Member Author

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@epassaro epassaro marked this pull request as ready for review April 25, 2022 23:48
@wkerzendorf wkerzendorf merged commit 04bded6 into tardis-sn:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions on how to fix .mailmap
3 participants